Skip to content

Commit d2f04eb

Browse files
committed
issue2551343 - Remove support for PySQLite and sqlite v2.
It is unmaintained and sqlite3 is used which is the default for a Python distribution.
1 parent 6068b47 commit d2f04eb

File tree

4 files changed

+19
-10
lines changed

4 files changed

+19
-10
lines changed

CHANGES.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@ Roundup 2.4.0 is the last release to support Python 2.
1616
2025-XX-XX 2.5.0
1717

1818
Fixed:
19+
- issue2551343 - Remove support for PySQLite. It is unmaintained and
20+
sqlite3 is used which is the default for a Python distribution.
21+
(John Rouillard)
1922

2023
Features:
2124

doc/upgrading.txt

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,20 @@ Contents:
9595
.. contents::
9696
:local:
9797

98-
.. index:: Upgrading; 2.2.0 to 2.3.0
98+
.. index:: Upgrading; 2.4.0 to 2.5.0
99+
100+
Migrating from 2.4.0 to 2.5.0
101+
=============================
102+
103+
Deprecation Notices (info)
104+
--------------------------
105+
106+
Support for SQLite version 2 has been removed in 2.5.0. Support for
107+
the `PySQLite <https://github.com/ghaering/pysqlite>`_ library has
108+
been removed in 2.5.0. Only the Python supplied sqlite3 library will
109+
be supported.
110+
111+
.. index:: Upgrading; 2.3.0 to 2.4.0
99112

100113
Migrating from 2.3.0 to 2.4.0
101114
=============================

roundup/backends/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
_modules = {
2929
'mysql': ('MySQLdb',),
3030
'postgresql': ('psycopg2',),
31-
'sqlite': ('pysqlite', 'pysqlite2', 'sqlite3', '_sqlite3', 'sqlite'),
31+
'sqlite': ('sqlite3', '_sqlite3'),
3232
}
3333

3434
def get_backend(name):

roundup/backends/back_sqlite.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -31,14 +31,7 @@
3131
import sqlite3 as sqlite
3232
sqlite_version = 3
3333
except ImportError:
34-
try:
35-
from pysqlite2 import dbapi2 as sqlite
36-
if sqlite.version_info < (2, 1, 0):
37-
raise ValueError('pysqlite2 minimum version is 2.1.0+ '
38-
'- %s found' % sqlite.version)
39-
sqlite_version = 2
40-
except ImportError:
41-
raise ValueError("Unable to import sqlite3 or sqlite 2.")
34+
raise ValueError("Unable to import sqlite3.")
4235

4336

4437
def db_exists(config):

0 commit comments

Comments
 (0)