handle the case where there is no file attached

Author: Richard Jones

CHANGES.txt

@@ -34,11 +34,17 @@ Fixed:
  . bug #479511 ] mailgw to pop
  . bug #479508 ] roundup-admin crash on wrong class
  . bad error report in hyperdb
+ . roundup.mailgw now handles errors on the set() and create() at the end
+   of processing
+ . roundup.mailgw also handles messages that are passed to it that don't
+   contain a From: line - apparently some POP servers can do this. It punts
+   an error message to the roundup admin.
  . fixed nosy reaction and author copy handling
  . errors in nosy reaction will be propogated now (were effectively being
    squashed)
  . re-open the database as the author in mail handling
 
+
 2001-10-23 - 0.3.0 pre 3
 Feature:
  . MailGW now moves 'unread' to 'chatting' on receiving e-mail for an issue.

roundup/cgi_client.py

@@ -15,7 +15,7 @@
 # BASIS, AND THERE IS NO OBLIGATION WHATSOEVER TO PROVIDE MAINTENANCE,
 # SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS.
 # 
-# $Id: cgi_client.py,v 1.56 2001-11-14 21:35:21 richard Exp $
+# $Id: cgi_client.py,v 1.57 2001-11-15 10:24:27 richard Exp $
 
 import os, cgi, pprint, StringIO, urlparse, re, traceback, mimetypes
 import binascii, Cookie, time
@@ -428,12 +428,13 @@ def _post_editnode(self, nid, changes=None):
         files = []
         if self.form.has_key('__file'):
             file = self.form['__file']
-            type = mimetypes.guess_type(file.filename)[0]
-            if not type:
-                type = "application/octet-stream"
-            # create the new file entry
-            files.append(self.db.file.create(type=type, name=file.filename,
-                content=file.file.read()))
+            if file.filename:
+                type = mimetypes.guess_type(file.filename)[0]
+                if not type:
+                    type = "application/octet-stream"
+                # create the new file entry
+                files.append(self.db.file.create(type=type, name=file.filename,
+                    content=file.file.read()))
 
         # generate an edit message
         # don't bother if there's no messages or nosy list 
@@ -966,6 +967,9 @@ def parsePropsFromForm(db, cl, form, nodeid=0):
 
 #
 # $Log: not supported by cvs2svn $
+# Revision 1.56  2001/11/14 21:35:21  richard
+#  . users may attach files to issues (and support in ext) through the web now
+#
 # Revision 1.55  2001/11/07 02:34:06  jhermann
 # Handling of damaged login cookies
 #

roundup/mailgw.py

@@ -72,7 +72,7 @@ class node. Any parts of other types are each stored in separate files
 an exception, the original message is bounced back to the sender with the
 explanatory message given in the exception. 
 
-$Id: mailgw.py,v 1.33 2001-11-13 21:44:44 richard Exp $
+$Id: mailgw.py,v 1.34 2001-11-15 10:24:27 richard Exp $
 '''
 
 
@@ -126,7 +126,7 @@ def main(self, fp):
     def handle_Message(self, message):
         '''Handle an RFC822 Message
 
-        Hanle the Message object by calling handle_message() and then cope
+        Handle the Message object by calling handle_message() and then cope
         with any errors raised by handle_message.
         This method's job is to make that call and handle any
         errors in a sane manner. It should be replaced if you wish to
@@ -521,6 +521,9 @@ def parseContent(content, blank_line=re.compile(r'[\r\n]+\s*[\r\n]+'),
 
 #
 # $Log: not supported by cvs2svn $
+# Revision 1.33  2001/11/13 21:44:44  richard
+#  . re-open the database as the author in mail handling
+#
 # Revision 1.32  2001/11/12 22:04:29  richard
 # oops, left debug in there
 #