API break, bumping version to 1.15.0, renamed TemplatesBase to

LoaderBase to correctly reflect semantics and avoid confusion.

Author: techtonik

CHANGES.txt

@@ -3,11 +3,13 @@ Entries are given with the most recent entry first.
 Each entry has the developer who committed the change in brackets.
 Entries without name were done by Richard Jones.
 
-2013-??-??: 1.4.22
+2013-??-??: 1.5.0
 
 Features:
 
-- ...
+- API changes. Renamed templating members to correctly reflect
+  the purpose of classes and avoid confusion (anatoly techtonik)
+    templating.TemplatesBase -> templating.LoaderBase
 
 Fixed:
 

roundup/cgi/engine_chameleon.py

@@ -5,9 +5,9 @@
 import os.path
 from chameleon import PageTemplateLoader
 
-from roundup.cgi.templating import StringIO, context, find_template, TemplatesBase
+from roundup.cgi.templating import StringIO, context, find_template, LoaderBase
 
-class Templates(TemplatesBase):
+class Templates(LoaderBase):
     def __init__(self, dir):
         self.dir = dir
         self.loader = PageTemplateLoader(dir)

roundup/cgi/engine_zopetal.py

@@ -8,14 +8,14 @@
 import os
 import os.path
 
-from roundup.cgi.templating import StringIO, context, translationService, find_template, TemplatesBase
+from roundup.cgi.templating import StringIO, context, translationService, find_template, LoaderBase
 from roundup.cgi.PageTemplates import PageTemplate, GlobalTranslationService
 from roundup.cgi.PageTemplates.Expressions import getEngine
 from roundup.cgi.TAL import TALInterpreter
 
 GlobalTranslationService.setGlobalTranslationService(translationService)
 
-class Templates(TemplatesBase):
+class Templates(LoaderBase):
     templates = {}
 
     def __init__(self, dir):

roundup/cgi/templating.py

@@ -117,8 +117,8 @@ def find_template(dir, name, view):
         'with template "%s" (neither "%s" nor "%s")'%(name, view,
         filename, generic))
 
-class TemplatesBase:
-    """Base for engine-specific Templates class."""
+class LoaderBase:
+    """Base for engine-specific template Loader class."""
     def precompileTemplates(self):
         """ Go through a directory and precompile all the templates therein
         """
@@ -149,10 +149,12 @@ def __getitem__(self, name):
         if extension:
             extension = extension[1:]
         try:
+            # [ ] dispell - add get() definition to this base class
             return self.get(name, extension)
         except NoTemplate, message:
             raise KeyError, message
 
+# [ ] rename to get_loader
 def get_templates(dir, engine_name):
     if engine_name == 'chameleon':
         import engine_chameleon as engine