Implement transitive props for sort and filter

.. in REST API.

Author: schlatterbeck

roundup/rest.py

@@ -685,6 +685,8 @@ def get_collection(self, class_name, input):
                         ss = '+'
                         pn = p
                     # Only include properties where we have search permission
+                    # Note that hasSearchPermission already returns 0 for
+                    # non-existing properties.
                     if self.db.security.hasSearchPermission(
                         uid, class_name, pn
                     ):
@@ -694,24 +696,34 @@ def get_collection(self, class_name, input):
                 # like @apiver
                 pass
             else: # serve the filter purpose
+                p = key.split('.', 1)[0]
                 try: 
-                    prop = class_obj.getprops()[key]
+                    prop = class_obj.getprops()[p]
                 except KeyError:
                     raise UsageError("Field %s is not valid for %s class."%(
-                        key, class_name))
+                        p, class_name))
                 # We drop properties without search permission silently
                 # This reflects the current behavior of other roundup
                 # interfaces
+                # Note that hasSearchPermission already returns 0 for
+                # non-existing properties.
                 if not self.db.security.hasSearchPermission(
                     uid, class_name, key
                 ):
                     continue
+
+                linkcls = class_obj
+                for p in key.split('.'):
+                    prop = linkcls.getprops(protected = True)[p]
+                    linkcls = getattr (prop, 'classname', None)
+                    if linkcls:
+                        linkcls = self.db.getclass(linkcls)
+
                 if isinstance (prop, (hyperdb.Link, hyperdb.Multilink)):
                     if key in filter_props:
                         vals = filter_props[key]
                     else:
                         vals = []
-                    linkcls = self.db.getclass (prop.classname)
                     for p in value.split(","):
                         if prop.try_id_parsing and p.isdigit():
                             vals.append(p)

test/rest_common.py

@@ -203,6 +203,44 @@ def testGet(self):
         self.assertEqual(self.dummy_client.response_code, 200)
         self.assertEqual(results['data']['data'], 'joe')
 
+    def testGetTransitive(self):
+        """
+        Retrieve all issues with an 'o' in status
+        sort by status.name (not order)
+        """
+        base_path = self.db.config['TRACKER_WEB'] + 'rest/data/'
+        #self.maxDiff=None
+        self.create_sampledata()
+        self.db.issue.set('2', status=self.db.status.lookup('closed'))
+        self.db.issue.set('3', status=self.db.status.lookup('chatting'))
+        expected={'data':
+                   {'@total_size': 2,
+                    'collection': [
+                      { 'id': '2',
+                        'link': base_path + 'issue/2',
+                        'status':
+                          { 'id': '10',
+                            'link': base_path + 'status/10'
+                          }
+                      },
+                      { 'id': '1',
+                        'link': base_path + 'issue/1',
+                        'status':
+                          { 'id': '9',
+                            'link': base_path + 'status/9'
+                          }
+                      },
+                    ]}
+                 }
+        form = cgi.FieldStorage()
+        form.list = [
+            cgi.MiniFieldStorage('status.name', 'o'),
+            cgi.MiniFieldStorage('@fields', 'status'),
+            cgi.MiniFieldStorage('@sort', 'status.name'),
+        ]
+        results = self.server.get_collection('issue', form)
+        self.assertDictEqual(expected, results)
+
     def testOutputFormat(self):
         """ test of @fields and @verbose implementation """