merge from maint-0-7

Author: Richard Jones

doc/announcement.txt

@@ -63,5 +63,5 @@ disutils-based install script is provided.
 
 It comes with two issue tracker templates (a classic bug/feature tracker and
 a minimal skeleton) and seven database back-ends (anydbm, bsddb, bsddb3,
-sqlite, metakit, mysql and postgresql). 
+sqlite, metakit, mysql and postgresql).
 

doc/developers.txt

@@ -2,7 +2,7 @@
 Developing Roundup
 ==================
 
-:Version: $Revision: 1.6 $
+:Version: $Revision: 1.7 $
 
 Note: the intended audience of this document is the developers of the core
 Roundup code. If you just wish to alter some behaviour of your Roundup
@@ -43,7 +43,7 @@ CVS stuff:
 
 1. to make a branch (eg. branching for code freeze/release)::
 
-    cvs co -d maint-0-5 -r release-0-5-0-pr1
+    cvs co -d maint-0-5 -r release-0-5-0-pr1 roundup
     cd maint-0-5 
     cvs tag -b maint-0-5
 

doc/index.txt

@@ -64,6 +64,7 @@ Thanks also to the many people on the mailing list, in the sourceforge
 project and those who just report bugs:
 Thomas Arendsen Hein,
 Anthony Baxter,
+Marlon van den Berg,
 Bo Berglund,
 Cameron Blackwood,
 Jeff Blaine,
@@ -77,6 +78,7 @@ Kelley Dagley,
 Paul F. Dubois,
 Jeff Epler,
 Tom Epperly,
+Tamer Fahmy,
 Hernan Martinez Foffani,
 Stuart D. Gathman,
 Ajit George,

doc/upgrading.txt

@@ -6,8 +6,40 @@ Please read each section carefully and edit your tracker home files
 accordingly. Note that there is information about upgrade procedures in the
 `administration guide`_.
 
+If a specific version transition isn't mentioned here (eg. 0.6.7 to 0.6.8)
+then you don't need to do anything. If you're upgrading from 0.5.6 to
+0.6.8 though, you'll need to check the "0.5 to 0.6" and "0.6.x to 0.6.3"
+steps.
+
 .. contents::
 
+Migrating from 0.7.0 to 0.7.1
+=============================
+
+0.7.1 Permission assignments
+----------------------------
+
+If you allow anonymous access to your tracker, you might need to assign
+some additional View (or Edit if your tracker is that open) permissions
+to the "anonymous" user. To do so, find the code in your ``dbinit.py`` that
+says::
+
+    for cl in 'issue', 'file', 'msg', 'query', 'keyword':
+        p = db.security.getPermission('View', cl)
+        db.security.addPermissionToRole('User', p)
+        p = db.security.getPermission('Edit', cl)
+        db.security.addPermissionToRole('User', p)
+    for cl in 'priority', 'status':
+        p = db.security.getPermission('View', cl)
+        db.security.addPermissionToRole('User', p)
+
+Add add a line::
+
+        db.security.addPermissionToRole('Anonymous', p)
+
+next to the existing ``'User'`` lines for the Permissions you wish to
+assign to the anonymous user.
+
 
 Migrating from 0.6 to 0.7
 =========================

roundup/backends/back_sqlite.py

@@ -1,4 +1,4 @@
-# $Id: back_sqlite.py,v 1.27 2004-05-02 23:16:05 richard Exp $
+# $Id: back_sqlite.py,v 1.28 2004-05-10 00:39:40 richard Exp $
 '''Implements a backend for SQLite.
 
 See https://pysqlite.sourceforge.net/ for pysqlite info
@@ -202,7 +202,7 @@ def update_class(self, spec, old_spec, force=0, adding_v2=0):
         self.create_class_table(spec)
 
         if olddata:
-            inscols = ['_actor', '_activity', '_creation', '_creator']
+            inscols = ['id', '_actor', '_activity', '_creation', '_creator']
             for propname,x in new_spec[1]:
                 prop = properties[propname]
                 if isinstance(prop, hyperdb.Multilink):

roundup/instance.py

@@ -15,7 +15,7 @@
 # BASIS, AND THERE IS NO OBLIGATION WHATSOEVER TO PROVIDE MAINTENANCE,
 # SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS.
 # 
-# $Id: instance.py,v 1.12 2004-02-11 23:55:08 richard Exp $
+# $Id: instance.py,v 1.13 2004-05-10 00:34:48 richard Exp $
 
 '''Tracker handling (open tracker).
 
@@ -44,7 +44,7 @@ def open(self):
 
 
     def _load_python(self, file):
-        file = os.path.join(tracker_home, file)
+        file = os.path.join(self.tracker_home, file)
         vars = Vars()
         execfile(file, vars.__dict__)
         return vars

roundup/rfc2822.py

@@ -18,6 +18,8 @@
 
 hqre = re.compile(r'^[A-z0-9!"#$%%&\'()*+,-./:;<=>?@\[\]^_`{|}~ ]+$')
 
+CRLF = '\r\n'
+
 def base64_decode(s, convert_eols=None):
     """Decode a raw base64 string.
 

roundup/scripts/roundup_server.py

@@ -17,7 +17,7 @@
 
 """Command-line script that runs a server over roundup.cgi.client.
 
-$Id: roundup_server.py,v 1.46 2004-04-20 21:57:16 richard Exp $
+$Id: roundup_server.py,v 1.47 2004-05-10 00:38:38 richard Exp $
 """
 __docformat__ = 'restructuredtext'
 
@@ -94,8 +94,8 @@ def run_cgi(self):
             self.inner_run_cgi()
         except client.NotFound:
             self.send_error(404, self.path)
-        except client.Unauthorised:
-            self.send_error(403, self.path)
+        except client.Unauthorised, message:
+            self.send_error(403, '%s (%s)'%(self.path, message))
         except:
             exc, val, tb = sys.exc_info()
             if hasattr(socket, 'timeout') and isinstance(val, socket.timeout):

templates/classic/html/help_controls.js

@@ -3,46 +3,6 @@
 
 original_field = window.opener.document.itemSynopsis[field].value;
 
-
-// pop() and push() methods for pre5.5 IE browsers
-
-function bName() {
-    // test for IE 
-    if (navigator.appName == "Microsoft Internet Explorer")
-      return 1;
-    return 0;
-}
-
-function bVer() {
-    // return version number (e.g., 4.03)
-    msieIndex = navigator.appVersion.indexOf("MSIE") + 5;
-    return(parseFloat(navigator.appVersion.substr(msieIndex,3)));
-}
-
-function pop() {
-    // make a pop method for old IE browsers
-    var lastElement = this[this.length - 1];
-    this.length--;
-    return lastElement;
-}
-
-function push() {
-    // make a pop method for old IE browsers
-    var sub = this.length;
-    for (var i = 0; i < push.arguments.length; ++i) {
-      this[sub] = push.arguments[i];
-        sub++;
-  }
-}
-
-// add the pop() and push() method to Array if they're not there
-if (!Array.prototype.pop) {
-    Array.prototype.pop = pop;
-}
-if (!Array.prototype.push) {
-    Array.prototype.push = push;
-}
-
 function trim(value) {
   var temp = value;
   var obj = /^(\s*)([\W\w]*)(\b\s*$)/;
@@ -53,21 +13,21 @@ function trim(value) {
 }
 
 function determineList() {
-  // generate a comma-separated list of the checked items
-  if (document.frm_help.check==undefined) { return; }
-  var list = new Array();
-  if (document.frm_help.check.length==undefined) {
-      if (document.frm_help.check.checked) {
-          list.push(document.frm_help.check.value);
-      }
-  } else {
-      for (box=0; box < document.frm_help.check.length; box++) {
-          if (document.frm_help.check[box].checked) {
-              list.push(document.frm_help.check[box].value);
-          }
-      }
-  }
-  return new String(list.join(','));
+    // generate a comma-separated list of the checked items
+    var list = new String('');
+    for (box=0; box < document.frm_help.check.length; box++) {
+        if (document.frm_help.check[box].checked) {
+            if (list.length == 0) {
+                separator = '';
+            }
+            else {
+                separator = ',';
+            }
+            // we used to use an Array and push / join, but IE5.0 sux
+            list = list + separator + document.frm_help.check[box].value;
+        }
+    }
+    return list;
 }
 
 function updateList() {

templates/classic/html/issue.search.html

@@ -3,7 +3,8 @@
 <span metal:fill-slot="body_title" tal:omit-tag="python:1">Issue searching</span>
 <td class="content" metal:fill-slot="content">
 
-<form method="GET" tal:attributes="action request/classname">
+<form method="GET" name="itemSynopsis"
+      tal:attributes="action request/classname">
 
 <table class="form" tal:define="
    cols python:request.columns or 'id activity title status assignedto'.split();