be paranoid about TRACKER_WEB

Author: Richard Jones

CHANGES.txt

@@ -17,6 +17,7 @@ Fixed:
 - export and import now include journals (incompatible with export < 0.7)
 - added "download_url" method to generate a correctly quoted URL for file
   download links (sf bug 927745)
+- all uses of TRACKER_WEB now ensure it ends with a '/'
 
 
 2004-03-27 0.7.0b2

roundup/cgi/actions.py

@@ -1,4 +1,4 @@
-#$Id: actions.py,v 1.22 2004-03-31 23:08:39 richard Exp $
+#$Id: actions.py,v 1.23 2004-04-05 06:13:42 richard Exp $
 
 import re, cgi, StringIO, urllib, Cookie, time, random
 
@@ -77,7 +77,7 @@ def handle(self, typere=re.compile('[@:]type'),
             d = {'input': n, 'classname': t}
             raise SeriousError, _(
                 '"%(input)s" is not an ID (%(classname)s ID required)')%d
-        url = '%s%s%s'%(self.db.config.TRACKER_WEB, t, n)
+        url = '%s%s%s'%(self.base, t, n)
         raise Redirect, url
 
 class RetireAction(Action):

roundup/cgi/client.py

@@ -1,4 +1,4 @@
-# $Id: client.py,v 1.169 2004-03-26 05:16:03 richard Exp $
+# $Id: client.py,v 1.170 2004-04-05 06:13:42 richard Exp $
 
 """WWW request handler (also used in the stand-alone server).
 """
@@ -109,6 +109,10 @@ def __init__(self, instance, request, env, form=None):
         # this is the base URL for this tracker
         self.base = self.instance.config.TRACKER_WEB
 
+        # check the tracker_we setting
+        if not self.base.endswith('/'):
+            self.base = self.base + '/'
+
         # this is the "cookie path" for this tracker (ie. the path part of
         # the "base" url)
         self.cookie_path = urlparse.urlparse(self.base)[2]

roundup/roundupdb.py

@@ -15,7 +15,7 @@
 # BASIS, AND THERE IS NO OBLIGATION WHATSOEVER TO PROVIDE MAINTENANCE,
 # SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS.
 # 
-# $Id: roundupdb.py,v 1.105 2004-03-27 00:12:11 richard Exp $
+# $Id: roundupdb.py,v 1.106 2004-04-05 06:13:42 richard Exp $
 
 """Extending hyperdb with types specific to issue-tracking.
 """
@@ -338,11 +338,12 @@ def email_signature(self, nodeid, msgid):
         base = self.db.config.TRACKER_WEB 
         if (not isinstance(base , type('')) or
             not (base.startswith('http://') or base.startswith('https://'))):
-            base = "Configuration Error: TRACKER_WEB isn't a " \
+            web = "Configuration Error: TRACKER_WEB isn't a " \
                 "fully-qualified URL"
-        elif base[-1] != '/' :
-            base += '/'
-        web = base + self.classname + nodeid
+        else:
+            if not base.endswith('/'):
+                base = base + '/'
+            web = base + self.classname + nodeid
 
         # ensure the email address is properly quoted
         email = straddr((self.db.config.TRACKER_NAME,