fallback for (list) popups if javascript disabled (patch [SF#1101626])

Author: Richard Jones

CHANGES.txt

@@ -23,6 +23,7 @@ Fixed:
 - removed rlog module (py 2.3 is minimum version now)
 - fixed class "help" listing paging (sf bug 1106329)
 - nicer error looking up values of None (response to sf bug 1108697)
+- fallback for (list) popups if javascript disabled (sf patch 1101626)
 
 
 2005-01-13 0.8.0b2

doc/index.txt

@@ -130,6 +130,7 @@ Florian Schulze,
 Klamer Schutte,
 Dougal Scott,
 Stefan Seefeld,
+Jouni K Sepp�nen,
 Jeffrey P Shell,
 Joel Shprentz,
 Terrel Shumway,

roundup/cgi/templating.py

@@ -651,10 +651,13 @@ def classhelp(self, properties=None, label=''"(list)", width='500',
             property = '&property=%s'%property
         if form:
             form = '&form=%s'%form
-        return '<a class="classhelp" href="javascript:help_window(\'%s?'\
-           '@startwith=0&amp;@template=help&amp;properties=%s%s%s\', \'%s\', \
-            \'%s\')">%s</a>'%(self.classname, properties, property, form, width,
-            height, self._(label))
+        help_url = "%s?@startwith=0&amp;@template=help&amp;"\
+                   "properties=%s%s%s" % \
+                   (self.classname, properties, property, form)
+        onclick = "javascript:help_window('%s', '%s', '%s');return false;" % \
+                  (help_url, width, height)
+        return '<a class="classhelp" href="%s" onclick="%s">%s</a>' % \
+               (help_url, onclick, self._(label))
 
     def submit(self, label=''"Submit New Entry"):
         ''' Generate a submit button (and action hidden element)