Fix issue2550826 third try. This limits the capture of exceptions to

Environment (includes the original IOError) and Arithmetic errors.  It
repackages these errors as detector exceptions so they can be reported.

This allows the detectors to raise Reject and other exceptions and
propagate them up from the detectors.

Author: rouilj

CHANGES.txt

@@ -99,7 +99,7 @@ Fixed:
 - issue2550907 Fix errors when creating documentation. Work done by
   Peter Funk (pefu). (Applied by John Rouillard with small change
   omitting obsolete security.txt.)
-- issue2550826 Capture all exceptions from auditors/reactors and
+- issue2550826 Capture some exceptions from auditors/reactors and
   raise a DetectorError instead. This allows failures like IOErrors
   from the detectors (e.g. unable to access files) to be handled.
   Previously an IOError just resulted in no output (premature end of

roundup/hyperdb.py

@@ -30,14 +30,6 @@
 from roundup.i18n import _
 from roundup.cgi.exceptions import DetectorError
 
-# import other errors that a detector is allowed to throw
-# so they can be raised and not captured by the DetectorError
-from roundup.exceptions import Reject, RejectRaw
-try:
-    from pytz import UnknownTimeZoneError
-except:
-    UnknownTimeZoneError = ValueError
-
 #
 # Types
 #
@@ -1302,11 +1294,7 @@ def fireAuditors(self, event, nodeid, newvalues):
         for prio, name, audit in self.auditors[event]:
             try:
                 audit(self.db, self, nodeid, newvalues)
-            except (Reject, RejectRaw, ValueError, UnknownTimeZoneError):
-                # these are raised by detectors to cause actions
-                # to occur at other levels. Reassert them.
-                raise
-            except Exception as e:
+            except (EnvironmentError, ArithmeticError) as e:
                 tb = traceback.format_exc()
                 html = ("<h1>Traceback</h1>" + str(tb).replace('\n', '<br>').
                         replace(' ', '&nbsp;'))
@@ -1324,11 +1312,7 @@ def fireReactors(self, event, nodeid, oldvalues):
         for prio, name, react in self.reactors[event]:
             try:
                 react(self.db, self, nodeid, oldvalues)
-            except (Reject, RejectRaw, ValueError):
-                # these are raised by detectors to cause actions
-                # to occur at other levels. Reassert them.
-                raise
-            except Exception as e:
+            except (EnvironmentError, ArithmeticError) as e:
                 tb = traceback.format_exc()
                 html = ("<h1>Traceback</h1>" + str(tb).replace('\n', '<br>').
                         replace(' ', '&nbsp;'))