issue2550932 - html_calendar produces templating errors for bad date strings

Changed code to trap and ignore unparsible dates. The calendar starts
with today highlighted.

Author: rouilj

CHANGES.txt

@@ -375,6 +375,9 @@ Fixed:
   space separated list not comma separated. This fixes the format of
   the id url parameter when generated by indexargs_form. (John
   Rouillard)
+- issue2550932 - html_calendar produces templating errors for bad date
+  strings. Fixed to ignore bad date and highlight todays date in the
+  calendar popup.
 
 2016-01-11: 1.5.1
 

roundup/cgi/templating.py

@@ -3031,8 +3031,19 @@ def html_calendar(self, request):
         template  = request.form.getfirst("@template", "calendar")
         form      = request.form.getfirst("form")
         property  = request.form.getfirst("property")
-        curr_date = date.Date(date_str) # to highlight
-        display   = date.Date(display)  # to show
+        curr_date = ""
+        try:
+            # date_str and display can be set to an invalid value
+            # if user submits a value like "d4" and gets an edit error.
+            # If either or both invalid just ignore that we can't parse it
+            # and assign them to today.
+            curr_date = date.Date(date_str) # to highlight
+            display   = date.Date(display)  # to show
+        except ValueError:
+            # we couldn't parse the date
+            # just let the calendar display
+            curr_date = current_date
+            display = current_date
         day       = display.day
 
         # for navigation