Fix [SF#1599740]

Author: stefanseefeld

CHANGES.txt

@@ -4,6 +4,7 @@ are given with the most recent entry first.
 
 2006-??-?? 1.3.2
 Fixed:
+- relax rules for required fields in form_parser.py (sf bug 1599740)
 - documentation cleanup from Luke Ross (sf patch 1594860)
 - updated Spanish translation from Ramiro Morales (sf patch 1594718)
 

ChangeLog

@@ -1,3 +1,8 @@
+2006-11-22  Stefan Seefeld  <[email protected]>
+
+	* roundup/cgi/form_parser.py: Allow required fields to be ommitted
+	if user doesn't have edit permission and the value is already set.
+
 2001-08-03 11:54  richard
 
 	* BUILD.txt, CHANGES.txt, README.txt, setup.py,
@@ -872,7 +877,10 @@
 
 	* cgitb.py, config.py, date.py, hyperdb.py, roundup-mailgw.py,
 	roundup.py, roundup_cgi.py, roundupdb.py, server.py, template.py:
-	Added CVS keywords $Id: ChangeLog,v 1.7 2001-08-03 02:12:07 anthonybaxter Exp $ and $Log: not supported by cvs2svn $ to all python files.
+	Added CVS keywords $Id: ChangeLog,v 1.8 2006-11-23 00:44:48 stefan Exp $ and $Log: not supported by cvs2svn $
+	Added CVS keywords $Id: ChangeLog,v 1.8 2006-11-23 00:44:48 stefan Exp $ and Revision 1.7  2001/08/03 02:12:07  anthonybaxter
+	Added CVS keywords $Id: ChangeLog,v 1.8 2006-11-23 00:44:48 stefan Exp $ and regenerated on Fri Aug  3 12:12:00 EST 2001
+	Added CVS keywords $Id: ChangeLog,v 1.8 2006-11-23 00:44:48 stefan Exp $ and to all python files.
 
 2001-07-19 15:46  anthonybaxter
 

roundup/cgi/form_parser.py

@@ -526,6 +526,19 @@ def parse(self, create=0, num_re=re.compile('^\d+$')):
                 if got.has_key(entry):
                     required.remove(entry)
 
+            # If a user doesn't have edit permission for a given property,
+            # but the property is already set in the database, we don't
+            # require a value.
+            if not (create or nodeid is None):
+                for entry in required[:]:
+                    if not self.db.security.hasPermission('Edit',
+                                                          self.client.userid,
+                                                          self.classname,
+                                                          entry):
+                        cl = self.db.classes[self.classname]
+                        if cl.get(nodeid, entry) is None:
+                            required.remove(entry)
+            
             # any required values not present?
             if not required:
                 continue