Skip to content

Commit bc90fff

Browse files
committed
refactor: replace boolean expr with named function call
Replace a confusing boolean expression with a the use_cached_tracker() method call.
1 parent c634b79 commit bc90fff

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

roundup/cgi/wsgi_handler.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -97,12 +97,16 @@ def __init__(self, home, debug=False, timing=False, lang=None,
9797
else:
9898
self.translator = None
9999

100-
if "cache_tracker" not in self.feature_flags or \
101-
self.feature_flags["cache_tracker"] is not False:
100+
if self.use_cached_tracker():
102101
self.tracker = roundup.instance.open(self.home, not self.debug)
103102
else:
104103
self.preload()
105104

105+
def use_cached_tracker(self):
106+
return (
107+
"cache_tracker" not in self.feature_flags or
108+
self.feature_flags["cache_tracker"] is not False)
109+
106110
@gen_trace_id()
107111
@store_trace_reason("wsgi")
108112
def __call__(self, environ, start_response):
@@ -135,8 +139,7 @@ def __call__(self, environ, start_response):
135139
else:
136140
form = BinaryFieldStorage(fp=environ['wsgi.input'], environ=environ)
137141

138-
if "cache_tracker" not in self.feature_flags or \
139-
self.feature_flags["cache_tracker"] is not False:
142+
if self.use_cached_tracker():
140143
client = self.tracker.Client(self.tracker, request, environ, form,
141144
self.translator)
142145
try:

0 commit comments

Comments
 (0)