Skip to content

Commit bc710fe

Browse files
author
Richard Jones
committed
add close() methods where they are missing!
1 parent 202d03c commit bc710fe

File tree

4 files changed

+14
-3
lines changed

4 files changed

+14
-3
lines changed

TODO.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ pending web allow multilink selections to select a "none" element to allow
5454
pending dist include the HTML in docs
5555

5656
bug web request.url is incorrect in cgi-bin environments
57-
bug web need to indicate that generated pages shouldn't be cached
5857

5958
done instance rename to "instance" to "tracker"
6059
done hyperdb write a backend for gadfly (it's as done as it's going to get)
@@ -82,6 +81,7 @@ done web fix double-submit by having new-item-submit redirect at end
8281
done web daemonify roundup-server (fork, logfile, pidfile)
8382
done web modify cgitb to display PageTemplate errors better
8483
done web have roundup.cgi pick up instance config from the environment
84+
done web indicate that generated pages shouldn't be cached
8585
done admin have "set" command be applicable to all items in a class, and
8686
also be able to unset properties (ie. set to None)
8787

roundup/backends/back_anydbm.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
# BASIS, AND THERE IS NO OBLIGATION WHATSOEVER TO PROVIDE MAINTENANCE,
1616
# SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS.
1717
#
18-
#$Id: back_anydbm.py,v 1.76 2002-09-12 05:51:42 richard Exp $
18+
#$Id: back_anydbm.py,v 1.77 2002-09-12 07:23:23 richard Exp $
1919
'''
2020
This module defines a backend that saves the hyperdatabase in a database
2121
chosen by anydbm. It is guaranteed to always be available in python
@@ -678,6 +678,11 @@ def rollback(self):
678678
self.destroyednodes = {}
679679
self.transactions = []
680680

681+
def close(self):
682+
''' Nothing to do
683+
'''
684+
pass
685+
681686
_marker = []
682687
class Class(hyperdb.Class):
683688
'''The handle to a particular class of nodes in a hyperdatabase.'''

roundup/backends/back_gadfly.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# $Id: back_gadfly.py,v 1.17 2002-09-12 05:51:42 richard Exp $
1+
# $Id: back_gadfly.py,v 1.18 2002-09-12 07:23:23 richard Exp $
22
__doc__ = '''
33
About Gadfly
44
============
@@ -790,6 +790,11 @@ def doSaveNode(self, classname, nodeid, node):
790790
# return the classname, nodeid so we reindex this content
791791
return (classname, nodeid)
792792

793+
def close(self):
794+
''' Close off the connection.
795+
'''
796+
self.conn.close()
797+
793798
#
794799
# The base Class class
795800
#

roundup/backends/back_metakit.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ def __init__(self, config, journaltag=None):
3333
self.security = security.Security(self)
3434

3535
os.umask(0002)
36+
3637
def post_init(self):
3738
if self.indexer.should_reindex():
3839
self.reindex()

0 commit comments

Comments
 (0)