fixes and re-enable mysql.

Author: rouilj

.github/workflows/ci-test.yml

@@ -28,8 +28,8 @@ jobs:
     #    os: [ubuntu-latest, macos-latest, windows-latest]
 
     env:
-    #  OS: ${{ matrix.os }}
-    PYTHON_VERSION: ${{ matrix.python-version }}
+      #  OS: ${{ matrix.os }}
+      - PYTHON_VERSION: ${{ matrix.python-version }}
 
     steps:
       # Checkout the latest code from the repo
@@ -57,19 +57,13 @@ jobs:
           sudo -u postgres psql -c "CREATE ROLE rounduptest WITH CREATEDB LOGIN PASSWORD 'rounduptest';" -U postgres
 
       - name: Install mysql/mariadb
-        if: ${{ false }}
         run: |
           sudo apt-get install mysql-server mysql-client
           # set up mysql database
           sudo sed -i -e '/^\[mysqld\]/,/^\[mysql/s/^max_allowed_packet.*/max_allowed_packet = 500M/' /etc/mysql/my.cnf
           cat /etc/mysql/my.cnf
           sudo service mysql restart
-          mysql -u root -e 'GRANT ALL ON rounduptest.* TO rounduptest@localhost IDENTIFIED BY "rounduptest";'
-          # HACK: workaround mysql bug: http://bugs.mysql.com/bug.php?id=74901
-          #   needed for test_mysql.mysqlDBTest.testFilteringSpecialChars
-          # plus others. Otherwise we get:
-          # COLLATION 'utf8_bin' is not valid for CHARACTER SET 'utf8mb4'
-          # sed -i 's/CREATE DATABASE \%s/CREATE DATABASE \%s COLLATE utf8_general_ci/' roundup/backends/back_mysql.py
+          sudo mysql -u root -e 'GRANT ALL ON rounduptest.* TO rounduptest@localhost IDENTIFIED BY "rounduptest";'
 
       - name: Update pip
         run: python -m pip install --upgrade pip