fix(i18n): fix incorrect lookup of some translations

The code had:

  _("some term %s here" % term)

this extracts the template, but looks up the string with %s replaced.
So the translation is broken. Changed to:

  _("some term %s here") % term

which looks up the template and substitutes in the translation of the
template.

Found by ruff INT ruleset.

Author: rouilj

roundup/backends/back_anydbm.py

@@ -212,7 +212,7 @@ def __getattr__(self, classname):
     def addclass(self, cl):
         cn = cl.classname
         if cn in self.classes:
-            raise ValueError(_('Class "%s" already defined.' % cn))
+            raise ValueError(_('Class "%s" already defined.') % cn)
         self.classes[cn] = cl
 
         # add default Edit and View permissions

roundup/backends/rdbms_common.py

@@ -629,8 +629,8 @@ def update_class(self, spec, old_spec, force=0):
 
         if not self.config.RDBMS_ALLOW_ALTER:
             raise DatabaseError(_(
-                'ALTER operation disallowed: %(old)r -> %(new)r.' % {
-                    'old': old_spec, 'new': new_spec}))
+                'ALTER operation disallowed: %(old)r -> %(new)r.') % {
+                    'old': old_spec, 'new': new_spec})
 
         logger = logging.getLogger('roundup.hyperdb.backend')
         logger.info('update_class %s' % spec.classname)
@@ -864,8 +864,8 @@ def create_class(self, spec):
         """
 
         if not self.config.RDBMS_ALLOW_CREATE:
-            raise DatabaseError(_('CREATE operation disallowed: "%s".' %
-                                  spec.classname))
+            raise DatabaseError(_('CREATE operation disallowed: "%s".') %
+                                  spec.classname)
 
         cols, mls = self.create_class_table(spec)
         self.create_journal_table(spec)
@@ -881,7 +881,7 @@ def drop_class(self, cn, spec):
         """
 
         if not self.config.RDBMS_ALLOW_DROP:
-            raise DatabaseError(_('DROP operation disallowed: "%s".' % cn))
+            raise DatabaseError(_('DROP operation disallowed: "%s".') % cn)
 
         properties = spec[1]
         # figure the multilinks
@@ -925,7 +925,7 @@ def addclass(self, cl):
         """
         cn = cl.classname
         if cn in self.classes:
-            raise ValueError(_('Class "%s" already defined.' % cn))
+            raise ValueError(_('Class "%s" already defined.') % cn)
         self.classes[cn] = cl
 
         # add default Edit and View permissions

roundup/backends/sessions_redis.py

@@ -76,8 +76,8 @@ def get(self, infoid, value, default=_marker):
             if default != self._marker:
                 return default
             raise KeyError(_('Key %(key)s not found in %(name)s '
-                             'database.' % {"name": self.name,
-                                            "key": escape(infoid)}))
+                             'database.') % {"name": self.name,
+                                            "key": escape(infoid)})
         return self.todict(v)[value]
 
     def getall(self, infoid):
@@ -95,8 +95,8 @@ def getall(self, infoid):
             # If so, we get a misleading error, but anydbm does the
             # same so....
             raise KeyError(_('Key %(key)s not found in %(name)s '
-                             'database.' % {"name": self.name,
-                                            "key": escape(infoid)}))
+                             'database.') % {"name": self.name,
+                                            "key": escape(infoid)})
 
         ''' def set_no_tranaction(self, infoid, **newvalues):
         """ this is missing transaction and may be affected by
@@ -190,8 +190,8 @@ def set(self, infoid, **newvalues):
                     break
                 except redis.exceptions.WatchError:
                     self.log_info(
-                        _('Key %(key)s changed in %(name)s db' %
-                          {"key": escape(infoid), "name": self.name})
+                        _('Key %(key)s changed in %(name)s db') %
+                          {"key": escape(infoid), "name": self.name}
                     )
             else:
                 try:

roundup/cgi/timestamp.py

@@ -29,7 +29,7 @@ def timecheck(self, field, delay):
         try:
             created = unpack_timestamp(self.form[field].value)
         except KeyError:
-            raise FormError(_("Form is corrupted, missing: %s." % field))
+            raise FormError(_("Form is corrupted, missing: %s.") % field)
         if time.time() - created < delay:
             raise FormError(_("Responding to form too quickly."))
         return True

roundup/rest.py

@@ -1110,7 +1110,7 @@ def get_attribute(self, class_name, item_id, attr_name, input):
         try:
             data = node.__getattr__(attr_name)
         except AttributeError:
-            raise UsageError(_("Invalid attribute %s" % attr_name))
+            raise UsageError(_("Invalid attribute %s") % attr_name)
         result = {
             'id': item_id,
             'type': str(type(data)),

roundup/roundupdb.py

@@ -137,7 +137,7 @@ def confirm_registration(self, otk):
             # Try to make error message less cryptic to the user.
             if str(e) == 'node with key "%s" exists' % username:
                 raise ValueError(
-                    _("Username '%s' already exists." % username))
+                    _("Username '%s' already exists.") % username)
             else:
                 raise
 

roundup/scripts/roundup_server.py

@@ -548,8 +548,8 @@ def start_response(self, headers, response):
 
 def error():
     exc_type, exc_value = sys.exc_info()[:2]
-    return _('Error: %(type)s: %(value)s' % {'type': exc_type,
-                                             'value': exc_value})
+    return _('Error: %(type)s: %(value)s') % {'type': exc_type,
+                                             'value': exc_value}
 
 
 def setgid(group):
@@ -840,11 +840,11 @@ class ThreadingServer(socketserver.ThreadingMixIn,
                 raise socket.error(_(
                     "Unable to bind to port %(port)s, "
                     "access not allowed, "
-                    "errno: %(errno)s %(msg)s" % {
+                    "errno: %(errno)s %(msg)s") % {
                         "port": self["PORT"],
                         "errno": e.args[0],
                         "msg": e.args[1]}
-                ))
+                )
 
             raise
         # change user and/or group