Skip to content

Commit b5a4284

Browse files
author
Johannes Gijsbers
committed
Add 'return' after failed permission checks in search/editCSV actions.
1 parent 48fc229 commit b5a4284

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

roundup/cgi/client.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# $Id: client.py,v 1.146 2003-11-13 05:56:48 richard Exp $
1+
# $Id: client.py,v 1.147 2003-11-21 21:59:05 jlgijsbers Exp $
22

33
__doc__ = """
44
WWW request handler (also used in the stand-alone server).
@@ -1125,7 +1125,8 @@ def editCSVAction(self):
11251125
# this is per-class only
11261126
if not self.editCSVPermission():
11271127
self.error_message.append(
1128-
_('You do not have permission to edit %s' %self.classname))
1128+
_('You do not have permission to edit %s' %self.classname))
1129+
return
11291130

11301131
# get the CSV module
11311132
if rcsv.error:
@@ -1237,6 +1238,7 @@ def searchAction(self, wcre=re.compile(r'[\s,]+')):
12371238
if not self.searchPermission():
12381239
self.error_message.append(
12391240
_('You do not have permission to search %s' %self.classname))
1241+
return
12401242

12411243
# add a faked :filter form variable for each filtering prop
12421244
props = self.db.classes[self.classname].getprops()

0 commit comments

Comments
 (0)