issue2550648 - partial fix for problem in this issue. Ezio Melotti

reported that the expression editor allowed the user to generate an
expression using retired values. To align the expression editor with
the simple dropdown search item, retired values are now removed from
the expression editor.

Do we really want this though? Supposed a keyword is retired and I
want to search for an issue with that retired keyword? Do we have a
best policy document that says to remove retired keywords from all
places it could possibly be used? It could be argued that the simple
search dropdown is wrong and should allow selecting retired values.

Author: rouilj

CHANGES.txt

@@ -252,6 +252,12 @@ Fixed:
   parts to this: 1) changes to the templates to properly define the
   __came_from form element. See ``upgrading.txt``. 2) code changes
   to the LoginAction code in roundup/cgi/actions.py.  (John Rouillard)
+- issue2550648 - partial fix for problem in this issue. Ezio Melotti
+  reported that the expression editor allowed the user to generate an
+  expression using retired values. To align the expression editor with
+  the simple dropdown search item, retired values are now removed from
+  the expression editor. (We have an open question as to whether this
+  is desirable.)
 
 2016-01-11: 1.5.1
 

roundup/cgi/KeywordsExpr.py

@@ -245,7 +245,7 @@ def list_nodes(request):
     prop = request.form.getfirst("property")
     cls = request.client.db.getclass(prop)
     items = []
-    for nodeid in cls.getnodeids():
+    for nodeid in cls.getnodeids(retired=0):
         l = cls.getnode(nodeid).items()
         l = dict([x for x in l if len(x) == 2])
         try: