Skip to content

Commit ae6d371

Browse files
author
Johannes Gijsbers
committed
Use roundup_server script in demo.py to reduce duplication
(first part of fixing [SF##798659]).
1 parent 6ce7e7c commit ae6d371

File tree

2 files changed

+19
-17
lines changed

2 files changed

+19
-17
lines changed

demo.py

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
#
33
# Copyright (c) 2003 Richard Jones ([email protected])
44
#
5-
# $Id: demo.py,v 1.5 2003-07-28 23:17:50 richard Exp $
5+
# $Id: demo.py,v 1.6 2003-10-25 11:41:06 jlgijsbers Exp $
66

77
import sys, os, string, re, urlparse
88
import shutil, socket, errno, BaseHTTPServer
@@ -81,18 +81,17 @@ def run_demo():
8181
port = int(port)
8282

8383
# ok, so start up the server
84-
from roundup.scripts.roundup_server import RoundupRequestHandler
85-
RoundupRequestHandler.TRACKER_HOMES = {'demo': home}
86-
httpd = BaseHTTPServer.HTTPServer((hostname, port), RoundupRequestHandler)
87-
print 'Server running - connect to:\n %s'%url
88-
print '1. Log in as "demo"/"demo" or "admin"/"admin".'
89-
print '2. Hit Control-C to stop the server.'
90-
print '3. Re-start the server by running "python demo.py" again.'
91-
print '4. Re-initialise the server by running "python demo.py nuke".'
92-
try:
93-
httpd.serve_forever()
94-
except KeyboardInterrupt:
95-
print 'Keyboard Interrupt: exiting'
84+
from roundup.scripts import roundup_server
85+
roundup_server.RoundupRequestHandler.TRACKER_HOMES = {'demo': home}
86+
87+
success_message = '''Server running - connect to:
88+
%s
89+
1. Log in as "demo"/"demo" or "admin"/"admin".
90+
2. Hit Control-C to stop the server.
91+
3. Re-start the server by running "python demo.py" again.
92+
4. Re-initialise the server by running "python demo.py nuke".''' % url
93+
94+
roundup_server.run(port, success_message)
9695

9796
if __name__ == '__main__':
9897
run_demo()

roundup/scripts/roundup_server.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
#
1717
""" HTTP Server that serves roundup.
1818
19-
$Id: roundup_server.py,v 1.30 2003-10-25 11:20:17 jlgijsbers Exp $
19+
$Id: roundup_server.py,v 1.31 2003-10-25 11:41:06 jlgijsbers Exp $
2020
"""
2121

2222
# python version check
@@ -263,7 +263,7 @@ def daemonize(pidfile):
263263
os.dup2(devnull, 1)
264264
os.dup2(devnull, 2)
265265

266-
def run():
266+
def run(port=8080, success_message=None):
267267
''' Script entry point - handle args and figure out what to to.
268268
'''
269269
# time out after a minute if we can
@@ -272,7 +272,6 @@ def run():
272272
socket.setdefaulttimeout(60)
273273

274274
hostname = ''
275-
port = 8080
276275
pidfile = None
277276
logfile = None
278277
try:
@@ -368,7 +367,11 @@ def run():
368367
# appending, unbuffered
369368
sys.stdout = sys.stderr = open(logfile, 'a', 0)
370369

371-
print _('Roundup server started on %(address)s')%locals()
370+
if success_message:
371+
print success_message
372+
else:
373+
print _('Roundup server started on %(address)s')%locals()
374+
372375
try:
373376
httpd.serve_forever()
374377
except KeyboardInterrupt:

0 commit comments

Comments
 (0)