remove some unreachable code. If condition is always the same.

There is a test:

  if not value: continue

then there is code below that at the same level that tests for:

  if value:

and

  if value is None:

Neither of these tests can be anything but the static values of True
and False respectively. Simplify code by removing the tests.

Author: rouilj

roundup/roundupdb.py

@@ -790,14 +790,10 @@ def generateCreateNote(self, issueid):
                 continue
             if isinstance(prop, hyperdb.Link):
                 link = self.db.classes[prop.classname]
-                if value:
-                    key = link.labelprop(default_to_id=1)
-                    if key:
-                        value = link.get(value, key)
-                else:
-                    value = ''
+                key = link.labelprop(default_to_id=1)
+                if key:
+                    value = link.get(value, key)
             elif isinstance(prop, hyperdb.Multilink):
-                if value is None: value = []  # noqa: E701
                 link = self.db.classes[prop.classname]
                 key = link.labelprop(default_to_id=1)
                 if key: