Skip to content

Commit ada6f69

Browse files
committed
merge - set self.language attribute when translator passed into Client()
2 parents d4752cf + 3f7c596 commit ada6f69

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

CHANGES.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,9 @@ Fixed:
4141
a multilink link "messages" that does not have a 'name' property
4242
causes a crash. (found/fix by cmeerw; commit and better handling of
4343
non-labeled multilink by John Rouillard)
44-
44+
- in cgi/client.py, set self.language attribute when translator passed
45+
into Client(). (John Rouillard)
46+
4547
Features:
4648

4749
- add support for authorized changes. User can be prompted to enter

roundup/cgi/client.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -452,9 +452,12 @@ def __init__(self, instance, request, env, form=None, translator=None):
452452
self.env = env
453453
if translator is not None:
454454
self.setTranslator(translator)
455-
# XXX we should set self.language to "translator"'s language,
456-
# but how to get it ?
457-
self.language = ""
455+
# set self.language to "translator"'s language
456+
try:
457+
self.language = translator.info()["language"]
458+
except (AttributeError, KeyError):
459+
# info() missing or no language key
460+
self.language = ""
458461
else:
459462
self.setTranslator(TranslationService.NullTranslationService())
460463
self.language = "" # as is the default from determine_language

0 commit comments

Comments
 (0)