backported fix to CGI form handling from 0.5

Richard Jones · Richard Jones · commit ac22f4e9fd9d · 2002-09-02T21:49:04.000Z
diff --git a/CHANGES.txt b/CHANGES.txt
@@ -5,6 +5,8 @@ are given with the most recent entry first.
 Fixed:
  . #600699 ] documentation in doc/getting_started.txt
  . #600700 ] doc/upgrading.txt: no info about 0.4.3
+ . #603703 ] way to unassign issues  (backported from 0.5.0)
+
 
 2002-07-25 0.4.3
 Fixed:
diff --git a/doc/announcement.txt b/doc/announcement.txt
@@ -1,5 +1,5 @@
 =================================================
-SC-Track Roundup 0.4.2 - an issue tracking system
+SC-Track Roundup 0.4.3 - an issue tracking system
 =================================================
 
 Note: If you have an existing roundup installation, make a backup of your
@@ -8,18 +8,18 @@ database. Make sure you read doc/upgrading.txt!
 Roundup requires python 2.1.1 for correct operation. Support for dumbdbm
 requires python 2.1.2 or 2.2. 2.1.3 and 2.2.1 are recommended.
 
-Big stuff in this release:
+This is a bugfix release, fixing:
 
-- online demo at http://mechanicalcat.net/cgi-bin/roundup.cgi
-- fast full-text searching of messages
-- other speedups
-- bsddb3 backend is re-enabled
-- instance initialisation is a two-step process now, making mods easier
-- optionally auto-add the author and recipients of messages to the nosy
-- enhancements to make multilink editing through the web and email easier
-- cleaner use of auditors and reactors in the default schemas
-- demo scripts supplied in the scripts/ and detectors/ directories
-- Much, much more: see the CHANGES file for details
+ . sf bug #576086: dumb copying mistake (frontends/ZRoundup.py)
+ . installation instructions now mention "python2" in "testing your python".
+ . bsddb3 backend should use 'c' for create, not 'n' for nuke
+ . sf bug #571170: gdbm deadlock
+ . sf bug #576241: MultiLink problems in parsePropsFromForm
+ . sf bug #516854: "My Issues" and redisplay
+ . htmltemplate do_menu with additional properties had problems when they
+   weren't set
+ . sf bug #562686: email attachments from outlook express
+ . sf bug #535868: Anonymous User Login
 
 Source and documentation is available at the website:
      http://roundup.sourceforge.net/
@@ -29,7 +29,6 @@ Mailing lists - the place to ask questions:
      http://sourceforge.net/mail/?group_id=31577
 
 
-
 About Roundup
 =============
 
diff --git a/doc/getting_started.txt b/doc/getting_started.txt
@@ -2,7 +2,7 @@
 Getting Started
 ===============
 
-:Version: $Revision: 1.3 $
+:Version: $Revision: 1.3.2.1 $
 
 .. contents::
 
@@ -45,26 +45,18 @@ Instances are created using the ``roundup-admin`` tool.
 Command Line Tool
 -----------------
 
-To initiliase a new instance, run "``roundup-admin init``". You will be asked a
-series of questions:
+To set up a new instance, run "``roundup-admin install``". You will be
+asked a few questions:
 
 1. Instance home directory
 2. Schema to use
 3. Database back-end to use
-4. Administration user "admin" password.
 
-You should also think about whether there is going to be controlled access
-to the
-instance on the machine the instance is running on. That is, who can
-actually make
-changes to the database using the roundup-admin tool. See the section on
-Users_and_Access_Control for information on how to secure your instance from the
-start.
-
-Roundup is configurable using an ``instance_config.py`` file in the instance
-home.  It
-should be edited before roundup is used, and may have the following variable
-declarations:
+Once you've chosen these, roundup will install the instance for you. It will
+then indicate that you should configure some more information in the
+file "``instance_config.py``" in the instance home.  It
+should be edited before roundup is initialised, and may have the following
+variable declarations:
 
 MAILHOST
    The SMTP mail host that roundup will use to send mail
@@ -81,6 +73,20 @@ ISSUE_TRACKER_EMAIL: ``issue_tracker@MAIL_DOMAIN``
 ADMIN_EMAIL: ``roundup-admin@MAIL_DOMAIN``
    roundup's internal use (problems, etc)
 
+You may also alter the default schema - see the `customisation`_ documentation
+for more info on both configuration variables and schema modifications.
+
+Once you're happy (and note that you can change any of this after the instance
+is initialised too!) you must run "``roundup-admin initialise``".
+
+You should also think about whether there is going to be controlled access
+to the
+instance on the machine the instance is running on. That is, who can
+actually make
+changes to the database using the roundup-admin tool. See the section on
+Users_and_Access_Control for information on how to secure your instance from the
+start.
+
 E-Mail Interface
 ----------------
 
@@ -160,7 +166,7 @@ Apache:
 	  SetEnv ROUNDUP_LOG "/var/log/roundup.log"
 	  SetEnv ROUNDUP_INSTANCE_HOMES "Default=/usr/local/share/roundup/instances/Default"
 	  SetEnv ROUNDUP_DEBUG "0"
-	  
+
   7. On Windows, write a batch file "roundup.bat" similar to the one below and
      place it into your cgi-bin directory::
       
@@ -269,4 +275,5 @@ Next: `User Guide`_
 
 .. _`table of contents`: index.html
 .. _`user guide`: user_guide.html
+.. _`customisation`: customizing.html
 
diff --git a/roundup/__init__.py b/roundup/__init__.py
@@ -15,7 +15,7 @@
 # BASIS, AND THERE IS NO OBLIGATION WHATSOEVER TO PROVIDE MAINTENANCE,
 # SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS.
 # 
-# $Id: __init__.py,v 1.9 2002-06-24 01:09:33 richard Exp $
+# $Id: __init__.py,v 1.9.2.1 2002-09-02 21:49:04 richard Exp $
 
 __doc__ = '''
 This is a simple-to-use and -install issue-tracking system with
@@ -65,10 +65,13 @@
 much prettier cake :)
 '''
 
-__version__ = '0.4.2'
+__version__ = '0.4.3'
 
 #
 # $Log: not supported by cvs2svn $
+# Revision 1.9  2002/06/24 01:09:33  richard
+# Modifications for the final 0.4.2 release.
+#
 # Revision 1.8  2002/06/21 00:24:53  richard
 # *baff* richard.
 #
diff --git a/roundup/cgi_client.py b/roundup/cgi_client.py
@@ -15,7 +15,7 @@
 # BASIS, AND THERE IS NO OBLIGATION WHATSOEVER TO PROVIDE MAINTENANCE,
 # SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS.
 # 
-# $Id: cgi_client.py,v 1.129.2.2 2002-07-22 22:06:45 richard Exp $
+# $Id: cgi_client.py,v 1.129.2.3 2002-09-02 21:49:04 richard Exp $
 
 __doc__ = """
 WWW request handler (also used in the stand-alone server).
@@ -1296,20 +1296,23 @@ class ExtendedClient(Client):
     default_index_columns = ['activity','status','title','assignedto']
     default_index_filterspec = {'status': ['1', '2', '3', '4', '5', '6', '7']}
 
-def parsePropsFromForm(db, cl, form, nodeid=0):
+def parsePropsFromForm(db, cl, form, nodeid=0, num_re=re.compile('^\d+$')):
     '''Pull properties for the given class out of the form.
     '''
     props = {}
     keys = form.keys()
-    num_re = re.compile('^\d+$')
     for key in keys:
         if not cl.properties.has_key(key):
             continue
         proptype = cl.properties[key]
         if isinstance(proptype, hyperdb.String):
             value = form[key].value.strip()
         elif isinstance(proptype, hyperdb.Password):
-            value = password.Password(form[key].value.strip())
+            value = form[key].value.strip()
+            if not value:
+                # ignore empty password values
+                continue
+            value = password.Password(value)
         elif isinstance(proptype, hyperdb.Date):
             value = form[key].value.strip()
             if value:
@@ -1326,8 +1329,7 @@ def parsePropsFromForm(db, cl, form, nodeid=0):
             value = form[key].value.strip()
             # see if it's the "no selection" choice
             if value == '-1':
-                # don't set this property
-                continue
+                value = None
             else:
                 # handle key values
                 link = cl.properties[key].classname
@@ -1340,7 +1342,7 @@ def parsePropsFromForm(db, cl, form, nodeid=0):
                             'value': value, 'classname': link}
         elif isinstance(proptype, hyperdb.Multilink):
             value = form[key]
-            if hasattr(value,'value'):
+            if hasattr(value, 'value'):
                 # Quite likely to be a FormItem instance
                 value = value.value
             if not isinstance(value, type([])):
@@ -1380,6 +1382,11 @@ def parsePropsFromForm(db, cl, form, nodeid=0):
 
 #
 # $Log: not supported by cvs2svn $
+# Revision 1.129.2.2  2002/07/22 22:06:45  richard
+# . #535868 ] Anonymous User Login
+#    Hrm, I re-read the intention of the web/email login stuff, and realised
+#    there was a quick fix.
+#
 # Revision 1.129.2.1  2002/07/10 06:50:49  richard
 # . #576241 ] MultiLink problems in parsePropsFromForm
 #
