Skip to content

Commit a89c2d9

Browse files
caulagicaulagi
committed
Don't use form elements to show read only data
1 parent 7e85ec7 commit a89c2d9

File tree

2 files changed

+74
-10
lines changed

2 files changed

+74
-10
lines changed

‎share/roundup/templates/responsive/html/bug.item.html‎

Lines changed: 39 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -39,20 +39,26 @@
3939

4040
<fieldset>
4141
<legend>classification</legend>
42-
<div class='container-fluid'>
42+
<div class='container-fluid' tal:condition="not:context/is_edit_ok">
43+
<dl class='dl-horizontal'>
44+
<dt i18n:translate="">Title</dt>
45+
<dd tal:content="structure context/title/plain"></dd>
46+
<dt i18n:translate="">Type</dt>
47+
<dd tal:content="structure context/type/plain"></dd>
48+
<dt i18n:translate="">Components</dt>
49+
<dd tal:content="structure context/components/plain"></dd>
50+
<dt i18n:translate="">Version</dt>
51+
<dd tal:content="structure context/versions/plain"></dd>
52+
</dl>
53+
</div>
54+
<div class='container-fluid' tal:condition="context/is_edit_ok">
4355
<!-- TITLE -->
4456
<div class='control-group vspace-two' tal:condition="context/title/is_edit_ok">
4557
<label class='control-label' for='bug_title' i18n:translate="">Title</label>
4658
<div class='controls'>
4759
<input class='input-xxlarge' type='text' name='title' id='bug_title' tal:attributes="value context/title">
4860
</div>
4961
</div>
50-
<div class='control-group vspace-two' tal:condition="not:context/title/is_edit_ok">
51-
<label class='control-label' i18n:translate="">Title</label>
52-
<div class='controls'>
53-
<span class='input-xxlarge uneditable-input' tal:content="structure context/title/plain"></span>
54-
</div>
55-
</div>
5662

5763
<div class='row-fluid'>
5864
<!-- TYPE -->
@@ -116,7 +122,31 @@
116122

117123
<fieldset>
118124
<legend>process</legend>
119-
<div class='container-fluid'>
125+
<div class='container-fluid' tal:condition="not:context/is_edit_ok">
126+
<div class='row-fluid'>
127+
<dl class='dl-horizontal span6'>
128+
<dt i18n:translate="">Status</dt>
129+
<dd tal:content="structure context/status/plain"></dd>
130+
<dt i18n:translate="">Resolution</dt>
131+
<dd tal:content="structure context/resolution/plain"></dd>
132+
<dt i18n:translate="">Dependencies</dt>
133+
<dd tal:content="structure context/dependencies/plain"></dd>
134+
<dt i18n:translate="">Superseder</dt>
135+
<dd tal:content="structure context/superseder/plain"></dd>
136+
</dl>
137+
<dl class='dl-horizontal span6'>
138+
<dt i18n:translate="">Assigned to</dt>
139+
<dd tal:content="structure context/assignee/plain"></dd>
140+
<dt i18n:translate="">Nosy list</dt>
141+
<dd tal:content="structure context/nosy/plain"></dd>
142+
<dt i18n:translate="">Priority</dt>
143+
<dd tal:content="structure context/priority/plain"></dd>
144+
<dt i18n:translate="">Keywords</dt>
145+
<dd tal:content="structure context/keywords/plain"></dd>
146+
</dl>
147+
</div>
148+
</div>
149+
<div class='container-fluid' tal:condition="context/is_edit_ok">
120150
<div class='row-fluid vspace-two'></div>
121151
<div class='row-fluid' tal:condition="context/id">
122152
<!-- Status -->
@@ -196,6 +226,7 @@
196226
<span tal:condition="context/nosy/is_edit_ok"
197227
tal:replace="structure python:db.user.classhelp('username,realname,address', property='nosy')" />
198228
<span tal:replace="structure context/nosy/field" />
229+
</div>
199230
</div>
200231
</div> <!-- row-fluid -->
201232

‎share/roundup/templates/responsive/html/task.item.html‎

Lines changed: 35 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,17 @@
4040

4141
<fieldset>
4242
<legend>classification</legend>
43-
<div class='container-fluid'>
43+
<div class='container-fluid' tal:condition="not:context/is_edit_ok">
44+
<dl class='dl-horizontal'>
45+
<dt i18n:translate="">Title</dt>
46+
<dd tal:content="structure context/title/plain"></dd>
47+
<dt i18n:translate="">Type</dt>
48+
<dd tal:content="structure context/type/plain"></dd>
49+
<dt i18n:translate="">Components</dt>
50+
<dd tal:content="structure context/components/plain"></dd>
51+
</dl>
52+
</div>
53+
<div class='container-fluid' tal:condition="context/is_edit_ok">
4454
<!-- TITLE -->
4555
<div class='control-group vspace-two' tal:condition="context/title/is_edit_ok">
4656
<label class='control-label' for='bug_title' i18n:translate="">Title</label>
@@ -88,7 +98,29 @@
8898

8999
<fieldset>
90100
<legend>process</legend>
91-
<div class='container-fluid'>
101+
<div class='container-fluid' tal:condition="not:context/is_edit_ok">
102+
<div class='row-fluid'>
103+
<dl class='dl-horizontal span6'>
104+
<dt i18n:translate="">Status</dt>
105+
<dd tal:content="structure context/status/plain"></dd>
106+
<dt i18n:translate="">Resolution</dt>
107+
<dd tal:content="structure context/resolution/plain"></dd>
108+
<dt i18n:translate="">Dependencies</dt>
109+
<dd tal:content="structure context/dependencies/plain"></dd>
110+
<dt i18n:translate="">Superseder</dt>
111+
<dd tal:content="structure context/superseder/plain"></dd>
112+
</dl>
113+
<dl class='dl-horizontal span6'>
114+
<dt i18n:translate="">Assigned to</dt>
115+
<dd tal:content="structure context/assignee/plain"></dd>
116+
<dt i18n:translate="">Nosy list</dt>
117+
<dd tal:content="structure context/nosy/plain"></dd>
118+
<dt i18n:translate="">Priority</dt>
119+
<dd tal:content="structure context/priority/plain"></dd>
120+
</dl>
121+
</div>
122+
</div>
123+
<div class='container-fluid' tal:condition="context/is_edit_ok">
92124
<div class='row-fluid vspace-two'></div>
93125
<div class='row-fluid' tal:condition="context/id">
94126
<!-- Status -->
@@ -168,6 +200,7 @@
168200
<span tal:condition="context/nosy/is_edit_ok"
169201
tal:replace="structure python:db.user.classhelp('username,realname,address', property='nosy')" />
170202
<span tal:replace="structure context/nosy/field" />
203+
</div>
171204
</div>
172205
</div> <!-- row-fluid -->
173206

0 commit comments

Comments
 (0)