Skip to content

Commit a88531e

Browse files
committed
Remove fix for old mysql bug; try to improve postgresql perf
Supposedly mysql bug that causes test_mysql.mysqlDBTest.testFilteringSpecialChars to fail was fixed in 8.0.1 in 2017: https://bugs.mysql.com/bug.php?id=74901 Also disable fsync for postgres as we prefer speed to durability of data when running test suite. Need to find correct path for postgrsql.conf, so ls command added as well.
1 parent cb2c50c commit a88531e

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

.travis.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -117,14 +117,13 @@ before_script:
117117
- sudo service mysql restart
118118
- mysql -u root -e 'CREATE USER "rounduptest"@"localhost" IDENTIFIED WITH mysql_native_password BY "rounduptest"; GRANT ALL on rounduptest.* TO "rounduptest"@"localhost";'
119119

120+
# Disable fsync for speed, don't care about data durability when testing
121+
- echo "fsync = off" >> /etc/postgresql/*/*/postgresql.conf
122+
- ls /etc/postgres
120123
- sudo service postgresql restart; sleep 30
121124
# set up postgresql database
122125
- psql -c "CREATE ROLE rounduptest WITH CREATEDB LOGIN PASSWORD 'rounduptest';" -U postgres
123126

124-
# HACK: workaround mysql bug: http://bugs.mysql.com/bug.php?id=74901
125-
# needed for test_mysql.mysqlDBTest.testFilteringSpecialChars
126-
- sed -i 's/CREATE DATABASE \%s/CREATE DATABASE \%s COLLATE utf8_general_ci/' roundup/backends/back_mysql.py
127-
128127
# build the .mo translation files and install them into a tree
129128
# (locale/locale under roundup directory root)
130129
# suitable for use by gettext.

0 commit comments

Comments
 (0)