Skip to content

Commit a510202

Browse files
author
Alexander Smishlajev
committed
use binary mode for csv export [SF#1195742];
remove universal newline mode from journals csv import
1 parent 64b329a commit a510202

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

roundup/admin.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
# BASIS, AND THERE IS NO OBLIGATION WHATSOEVER TO PROVIDE MAINTENANCE,
1717
# SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS.
1818
#
19-
# $Id: admin.py,v 1.85.2.6 2005-05-02 06:13:10 richard Exp $
19+
# $Id: admin.py,v 1.85.2.7 2005-05-06 06:53:00 a1s Exp $
2020

2121
'''Administration commands for maintaining Roundup trackers.
2222
'''
@@ -1063,7 +1063,7 @@ class colon_separated(csv.excel):
10631063
for classname in classes:
10641064
cl = self.get_class(classname)
10651065

1066-
f = open(os.path.join(dir, classname+'.csv'), 'w')
1066+
f = open(os.path.join(dir, classname+'.csv'), 'wb')
10671067
writer = csv.writer(f, colon_separated)
10681068

10691069
properties = cl.getprops()
@@ -1082,7 +1082,7 @@ class colon_separated(csv.excel):
10821082
f.close()
10831083

10841084
# export the journals
1085-
jf = open(os.path.join(dir, classname+'-journals.csv'), 'w')
1085+
jf = open(os.path.join(dir, classname+'-journals.csv'), 'wb')
10861086
journals = csv.writer(jf, colon_separated)
10871087
map(journals.writerow, cl.export_journals())
10881088
jf.close()
@@ -1146,7 +1146,7 @@ class colon_separated(csv.excel):
11461146
f.close()
11471147

11481148
# import the journals
1149-
f = open(os.path.join(args[0], classname + '-journals.csv'), 'rU')
1149+
f = open(os.path.join(args[0], classname + '-journals.csv'), 'r')
11501150
reader = csv.reader(f, colon_separated)
11511151
cl.import_journals(reader)
11521152
f.close()

0 commit comments

Comments
 (0)