Skip to content

Commit a1b8021

Browse files
committed
fix,docs: Move args around into groups; add docs.
Create basic and advanced user ARG groups; add some doc explanations.
1 parent d4485f1 commit a1b8021

File tree

1 file changed

+19
-11
lines changed

1 file changed

+19
-11
lines changed

scripts/Docker/Dockerfile

Lines changed: 19 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -8,24 +8,32 @@
88
# docker run --rm -v /.../issue.tracker:/usr/src/app/tracker \
99
# -p 9017:8080 roundup-app:latest
1010

11+
# arguments expected to be useful on command line. Lower case names.
12+
13+
# Source of roundup code:
14+
# 'local' directory using setup.py,
15+
# 'pypi[...]' to install latest final or version specified release
16+
# from PyPI, E.G. pypi=2.4; pypi<2.3 etc. All pip version specifiers
17+
# are allowed.
18+
# 'pip_local' local directory using pip to install, or
19+
# 'pip_sdist' to install dist/newest_version-tarball
20+
ARG source=local
21+
22+
# Internal settings that are for advanced users to override.
23+
1124
# parameterize the sha256 sum to pin version of python:3-alpine
25+
# Must use the same version in both build stages.
1226
ARG SHA256=5d769f990397afbb2aca24b0655e404c0f2806d268f454b052e81e39d87abf42
1327

14-
# Global vars for all build stages
28+
# Set to any non-empy value to enable shell debugging for troubleshooting
1529
ARG VERBOSE=
1630

1731
# application directory
1832
ARG appdir=/usr/src/app
1933

20-
# support roundup install from 'local' directory,
21-
# 'pypi' to install latest final or version specified release
22-
# from PyPI,
23-
# 'pip_local' local directory using pip to install, or
24-
# 'pip_sdist' to install dist/newest_version-tarball
25-
ARG source=local
26-
27-
# Python version as a.b Used for installation directory and
28-
# COPY from install dir in second stage.
34+
# Python version as a.b Used as path component for
35+
# installation directory and COPY from install dir
36+
# in second build stage.
2937
ARG pythonversion=3.11
3038

3139
#FROM python:3-alpine via SHA256 sum
@@ -119,7 +127,7 @@ COPY frontends install/frontends/
119127
COPY locale install/locale/
120128
COPY roundup install/roundup/
121129
COPY share install/share/
122-
# dist is optional so include README.txt so we don't get an error
130+
# dist/* might not exist, so include README.txt so we don't get an error
123131
COPY README.txt dist/* install/dist/
124132

125133
# verify source has one of two valid values then

0 commit comments

Comments
 (0)