fix: replace except: with except Exception: (by haosenwang1018@github)

Remove bare 'except:' statements replace with 'except Exception'.

In roundup_xmlrpc_server.py I changed Exception to BaseException so
the database gets closed on signals as well. The rest of the changes
do not look like they affect data integrity and are commited as
supplied.

Author: rouilj

CHANGES.txt

@@ -45,6 +45,8 @@ Fixed:
   into Client(). (John Rouillard)
 - issue2551393 -  Named searches lose their name in title when next
   page is selected. (John Rouillard)
+- code cleanup replace bare except: with except Exception:. (patch by
+  Sense_wang (haosenwang1018) applied by John Rouillard)
 
 Features:
 

frontends/ZRoundup/ZRoundup.py

@@ -210,7 +210,7 @@ def index_html(self, REQUEST=None):
         except client.NotFound:
             raise Exception('NotFound ' + REQUEST.URL)
             pass
-        except:
+        except Exception:
             import traceback
             traceback.print_exc()
             # all other exceptions in roundup are valid

roundup/anypy/vendored/cgi.py

@@ -870,7 +870,7 @@ def g(f=f):
             f()
         print("<H3>What follows is a test, not an actual exception:</H3>")
         g()
-    except:
+    except Exception:
         print_exception()
 
     print("<H1>Second try with a small maxlen...</H1>")
@@ -883,7 +883,7 @@ def g(f=f):
         print_arguments()
         print_form(form)
         print_environ(environ)
-    except:
+    except Exception:
         print_exception()
 
 def print_exception(type=None, value=None, tb=None, limit=None):

roundup/backends/rdbms_common.py

@@ -2612,7 +2612,7 @@ def collect_values(n):
             e.context['class'] = pln
             e.context['attr'] = prp
             raise
-        except:
+        except Exception:
             pass
         # Fallback to original code
         args = []
@@ -2693,7 +2693,7 @@ def collect_values(n):
             e.context['class'] = classname
             e.context['attr'] = proptree.name
             raise
-        except:
+        except Exception:
             # fallback behavior when expression parsing above fails
             orclause = ''
             if '-1' in v:

roundup/cgi/PageTemplates/PageTemplate.py

@@ -106,7 +106,7 @@ def pt_errors(self):
         if not self.expand: return
         try:
             self.pt_render(source=1)
-        except:
+        except Exception:
             return ('Macro expansion failed', '%s: %s' % sys.exc_info()[:2])
 
     def pt_warnings(self):
@@ -147,7 +147,7 @@ def read(self):
                 return self._text
             try:
                 return self.pt_render(source=1)
-            except:
+            except Exception:
                 return ('%s\n Macro expansion failed\n %s\n-->\n%s' %
                         (self._error_start, "%s: %s" % sys.exc_info()[:2],
                          self._text) )
@@ -177,7 +177,7 @@ def _cook(self):
         try:
             parser.parseString(self._text)
             self._v_program, self._v_macros = parser.getCode()
-        except:
+        except Exception:
             self._v_errors = ["Compilation failed",
                               "%s: %s" % sys.exc_info()[:2]]
         self._v_warnings = parser.getWarnings()

roundup/cgi/PageTemplates/PythonExpr.py

@@ -36,7 +36,7 @@ def __init__(self, name, expr, engine):
             self.f_code = 'def f():\n return %s\n' % expr.strip()
             exec(self.f_code, d)
             self._f = d['f']
-        except:
+        except Exception:
             raise CompilerError(('Python expression error:\n'
                                  '%s: %s') % exc_info()[:2])
         self._get_used_names()

roundup/cgi/TAL/DummyEngine.py

@@ -118,7 +118,7 @@ def evaluate(self, expression):
         if type == "python":
             try:
                 return eval(expr, self.globals, self.locals)
-            except:
+            except Exception:
                 raise TALESError("evaluation error in %s" % repr(expr))
         if type == "position":
             # Insert the current source file name, line number,

roundup/cgi/TAL/TALInterpreter.py

@@ -724,7 +724,7 @@ def do_onError_tal(self, block_handler):
         self._stream_write = stream.write
         try:
             self.interpret(block)
-        except:
+        except Exception:
             exc = sys.exc_info()[1]
             self.restoreState(state)
             engine = self.engine

roundup/cgi/ZTUtils/Iterator.py

@@ -189,7 +189,7 @@ def _supports(self, ob):
         try:
             if hasattr(ob, 'next') and (ob is iter(ob)):
                 return 1
-        except:
+        except Exception:
             return 0
 
     def prep_next(self, it):

roundup/cgi/templating.py

@@ -2717,7 +2717,7 @@ def __init__(self, *args, **kwargs):
             # ignore these errors to preserve user input
             try:
                 display_value.sort(key=keyfun)
-            except:
+            except Exception:
                 pass
             self._value = display_value