Fixed a couple of failing tests for *LoginRedirect in test_actions.py after url validation. Also raise ValueError from examine_url if base url is None.

Author: rouilj

roundup/cgi/actions.py

@@ -82,7 +82,10 @@ def examine_url(self, url):
         '''
 
         parsed_url_tuple = urllib_.urlparse(url)
-        parsed_base_url_tuple = urllib_.urlparse(self.base)
+        if self.base:
+            parsed_base_url_tuple = urllib_.urlparse(self.base)
+        else:
+            raise ValueError(self._("Base url not set. Check configuration."))
 
         info={ 'url': url,
                'base_url': self.base,

test/test_actions.py

@@ -23,6 +23,7 @@ def setUp(self):
         self.client.add_ok_message = lambda x : add_message(
             self.client._ok_message, x)
         self.client.form = self.form
+        self.client.base = "http://whoami.com/path/"
         class TemplatingUtils:
             pass
         self.client.instance.interfaces.TemplatingUtils = TemplatingUtils
@@ -323,8 +324,8 @@ def opendb(username):
 
         # test if we are logged out; should kill the @action=logout
         self.form.value[:] = []         # clear out last test's setup values
-        self.assertLoginRaisesRedirect("http://localhost:9017/demo/issue39?%40startwith=0&%40pagesize=50",
-                                 'foo', 'right', "http://localhost:9017/demo/issue39?@action=logout&@pagesize=50&@startwith=0")
+        self.assertLoginRaisesRedirect("http://whoami.com/path/issue39?%40startwith=0&%40pagesize=50",
+                                 'foo', 'right', "http://whoami.com/path/issue39?@action=logout&@pagesize=50&@startwith=0")
 
     def testInvalidLoginRedirect(self):
         self.client.db.security.hasPermission = lambda *args, **kwargs: True