Skip to content

Commit 9a41c8d

Browse files
committed
Mitigation for issue2551246 -u opton to roundup-admin
The -u option ignores the password and doesn't limit access to the data. Not a huge issue as currently anybody running it must have read access to the tracker home and all the credentials. So they can change the data directly using a db client or read anything they want. But this wasn't documented. Now it is.
1 parent c4405e6 commit 9a41c8d

File tree

4 files changed

+36
-1
lines changed

4 files changed

+36
-1
lines changed

CHANGES.txt

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@ Fixed:
5050
more than one issue with a matching parent message, fall back to
5151
subject matching. See upgrading.txt for details. (John Rouillard)
5252
- issue2551195 - port scripts from optparse to argparse (Ralf Schlatterbeck)
53+
- issue2551246 - mitigation, document how -u doesn't work for
54+
roundup-admin. (John Rouillard)
5355

5456
Features:
5557

@@ -182,6 +184,9 @@ Fixed:
182184
if the user doesn't have edit permissions. (John Rouillard)
183185
- issue2551216 - create new mysql databases using COLLATE
184186
utf8_general_ci to prevent crashes in test suite. (John Rouillard)
187+
- issue2551146 - fix issues with strings that have multiple %s
188+
substutions that were not labeled making i18n difficult/impossible.
189+
(John Rouillard)
185190

186191
Features:
187192

doc/admin_guide.txt

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -878,6 +878,22 @@ A brief (incomplete) summary is::
878878

879879
Run ``roundup-admin help commands`` for a complete list of subcommands.
880880

881+
One thing to note, The ``-u user`` setting does not currently operate
882+
like a user logging in via the web. The user running roundup-admin
883+
must have read access to the tracker home directory. As a result the
884+
user has access to the files and the database info contained in
885+
config.ini.
886+
887+
Using ``-u user`` sets the actor/user parameter in the
888+
journal. Changes that are made are attributed to that
889+
user. The password is ignored if provided. Any existing
890+
username has full access to the data just like the admin
891+
user. This is an area for further development so that
892+
roundup-admin could be used with sudo to provide secure
893+
command line access to a tracker.
894+
895+
In general you should forget that there is a -u parameter.
896+
881897
.. _`customisation documentation`: customizing.html
882898
.. _`upgrading documentation`: upgrading.html
883899
.. _`installation documentation`: installation.html

doc/user_guide.txt

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -850,6 +850,20 @@ login may be specified as either "``name``" or "``name:password``".
850850
If either the name or password is not supplied, they are obtained from
851851
the command-line.
852852

853+
The ``-u user`` setting does not currently operate like a
854+
user logging in via the web. The user running roundup-admin
855+
must have read access to the tracker home directory. As a
856+
result the user has access to the files and the database
857+
info contained in config.ini.
858+
859+
Using ``-u user`` sets the actor/user parameter in the
860+
journal. Changes that are made are attributed to that
861+
user. The password is ignored if provided. Any existing
862+
username has full access to the data just like the admin
863+
user. This is an area for further development so that
864+
roundup-admin could be used with sudo to provide secure
865+
command line access to a tracker.
866+
853867
When you initialise a new tracker instance you are prompted for the
854868
admin password. If you want to initialise a tracker non-interactively
855869
you can put the initialise command and password on the command

roundup/admin.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ def help_all(self):
240240
. ROUNDUP_LOGIN environment variable
241241
. the -u command-line option
242242
If either the name or password is not supplied, they are obtained from the
243-
command-line.
243+
command-line. (See admin guide before using -u.)
244244
245245
Date format examples:
246246
"2000-04-17.03:45" means <Date 2000-04-17.08:45:00>

0 commit comments

Comments
 (0)