Skip to content

Commit 93136cb

Browse files
committed
Suppress the "... - nothing changed" status banner presented when a
form is submitted. This is triggered only when only quiet properties are changed. See: https://sourceforge.net/p/roundup/mailman/roundup-users/thread/20170421012107.E 040180690%40vm71.cs.umb.edu/ with subject: [Roundup-users] Does anybody think feedback saying "nothing changed" is useful?
2 parents b0639a1 + 463fb1b commit 93136cb

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

roundup/cgi/actions.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -634,8 +634,13 @@ def _editnodes(self, all_props, all_links):
634634
self._('%(class)s %(id)s %(properties)s edited ok')
635635
% {'class':cn, 'id':nodeid, 'properties':info})
636636
else:
637-
m.append(self._('%(class)s %(id)s - nothing changed')
638-
% {'class':cn, 'id':nodeid})
637+
# this used to produce a message like:
638+
# issue34 - nothing changed
639+
# which is confusing if only quiet properties
640+
# changed for the class/id. So don't report
641+
# anything is the user didn't explicitly change
642+
# a visible (non-quiet) property.
643+
pass
639644
else:
640645
assert props
641646

0 commit comments

Comments
 (0)