strings have an __iter__ method on Python 3, but we don't want to consider them iterable

Author: cmeerw

roundup/backends/back_anydbm.py

@@ -957,7 +957,7 @@ def create_inner(self, **propvalues):
             elif isinstance(prop, hyperdb.Multilink):
                 if value is None:
                     value = []
-                if not hasattr(value, '__iter__'):
+                if not hasattr(value, '__iter__') or type(value) == type(''):
                     raise TypeError('new property "%s" not an iterable of ids'%key)
 
                 # clean up and validate the list of links
@@ -1265,7 +1265,7 @@ def set_inner(self, nodeid, **propvalues):
             elif isinstance(prop, hyperdb.Multilink):
                 if value is None:
                     value = []
-                if not hasattr(value, '__iter__'):
+                if not hasattr(value, '__iter__') or type(value) == type(''):
                     raise TypeError('new property "%s" not an iterable of'
                         ' ids'%propname)
                 link_class = self.properties[propname].classname

roundup/backends/rdbms_common.py

@@ -1614,7 +1614,7 @@ def create_inner(self, **propvalues):
             elif isinstance(prop, Multilink):
                 if value is None:
                     value = []
-                if not hasattr(value, '__iter__'):
+                if not hasattr(value, '__iter__') or type(value) == type(''):
                     raise TypeError('new property "%s" not an iterable of ids'%key) 
                 # clean up and validate the list of links
                 link_class = self.properties[key].classname
@@ -1874,7 +1874,7 @@ def set_inner(self, nodeid, **propvalues):
             elif isinstance(prop, Multilink):
                 if value is None:
                     value = []
-                if not hasattr(value, '__iter__'):
+                if not hasattr(value, '__iter__') or type(value) == type(''):
                     raise TypeError('new property "%s" not an iterable of'
                         ' ids'%propname)
                 link_class = self.properties[propname].classname