mysql table creation syntax change

The MySQL people gratuitously changed the syntax for specifying the storage
engine a while back and the current alpha drops support for the old syntax.
This patch changes TYPE to ENGINE in the mysql backend and updates the
documentation to show that we require MySQL 4.0.18 because of that. I also
removed a note in the mysql docs about a bug in InnoDB that has been fixed as
of the required version.

This fixes [SF#1727529]

Author: Justus Pendleton

doc/mysql.txt

@@ -2,7 +2,7 @@
 MySQL Backend
 =============
 
-:version: $Revision: 1.12 $
+:version: $Revision: 1.13 $
 
 This notes detail the MySQL backend for the Roundup issue tracker.
 
@@ -13,19 +13,13 @@ Prerequisites
 To use MySQL as the backend for storing roundup data, you also need 
 to install:
 
-1. MySQL RDBMS 4.0.16 or higher - http://www.mysql.com. Your MySQL
+1. MySQL RDBMS 4.0.18 or higher - http://www.mysql.com. Your MySQL
    installation MUST support InnoDB tables (or Berkeley DB (BDB) tables
-   if you have no other choice). If you're running < 4.0.16 (but not <4.0)
+   if you have no other choice). If you're running < 4.0.18 (but not <4.0)
    then you'll need to use BDB to pass all unit tests. Edit the
    ``roundup/backends/back_mysql.py`` file to enable DBD instead of InnoDB.
 2. Python MySQL interface - http://sourceforge.net/projects/mysql-python
 
-.. note::
-   The InnoDB implementation has a bug__ that Roundup tickles. See
-
-__ http://bugs.mysql.com/bug.php?id=1810
-
-
 Running the MySQL tests
 =======================
 

roundup/backends/back_mysql.py

@@ -1,4 +1,4 @@
-#$Id: back_mysql.py,v 1.72 2007-06-21 07:35:50 schlatterbeck Exp $
+#$Id: back_mysql.py,v 1.73 2007-09-28 15:26:10 jpend Exp $
 #
 # Copyright (c) 2003 Martynas Sklyzmantas, Andrey Lebedev <[email protected]>
 #
@@ -166,10 +166,10 @@ def open_connection(self):
             if message[0] != ER.NO_SUCH_TABLE:
                 raise DatabaseError, message
             self.init_dbschema()
-            self.sql("CREATE TABLE `schema` (`schema` TEXT) TYPE=%s"%
+            self.sql("CREATE TABLE `schema` (`schema` TEXT) ENGINE=%s"%
                 self.mysql_backend)
             self.sql('''CREATE TABLE ids (name VARCHAR(255),
-                num INTEGER) TYPE=%s'''%self.mysql_backend)
+                num INTEGER) ENGINE=%s'''%self.mysql_backend)
             self.sql('create index ids_name_idx on ids(name)')
             self.create_version_2_tables()
 
@@ -194,22 +194,22 @@ def create_version_2_tables(self):
         # OTK store
         self.sql('''CREATE TABLE otks (otk_key VARCHAR(255),
             otk_value TEXT, otk_time FLOAT(20))
-            TYPE=%s'''%self.mysql_backend)
+            ENGINE=%s'''%self.mysql_backend)
         self.sql('CREATE INDEX otks_key_idx ON otks(otk_key)')
 
         # Sessions store
         self.sql('''CREATE TABLE sessions (session_key VARCHAR(255),
             session_time FLOAT(20), session_value TEXT)
-            TYPE=%s'''%self.mysql_backend)
+            ENGINE=%s'''%self.mysql_backend)
         self.sql('''CREATE INDEX sessions_key_idx ON
             sessions(session_key)''')
 
         # full-text indexing store
         self.sql('''CREATE TABLE __textids (_class VARCHAR(255),
             _itemid VARCHAR(255), _prop VARCHAR(255), _textid INT)
-            TYPE=%s'''%self.mysql_backend)
+            ENGINE=%s'''%self.mysql_backend)
         self.sql('''CREATE TABLE __words (_word VARCHAR(30),
-            _textid INT) TYPE=%s'''%self.mysql_backend)
+            _textid INT) ENGINE=%s'''%self.mysql_backend)
         self.sql('CREATE INDEX words_word_ids ON __words(_word)')
         self.sql('CREATE INDEX words_by_id ON __words (_textid)')
         self.sql('CREATE UNIQUE INDEX __textids_by_props ON '
@@ -467,7 +467,7 @@ def drop_journal_table_indexes(self, classname):
 
     def create_multilink_table(self, spec, ml):
         sql = '''CREATE TABLE `%s_%s` (linkid VARCHAR(255),
-            nodeid VARCHAR(255)) TYPE=%s'''%(spec.classname, ml,
+            nodeid VARCHAR(255)) ENGINE=%s'''%(spec.classname, ml,
                 self.mysql_backend)
         self.sql(sql)
         self.create_multilink_table_indexes(spec, ml)