- issue2551074 - In "responsive" template: click on hide comment leads

  to a red error msg.

to files in responsive template reference the 'icing' macro. This was
replaced by a 'frame' macro in the responsive template.

Author: rouilj

CHANGES.txt

@@ -26,6 +26,8 @@ Fixed:
 - issue2551131 - Return accept-patch if patch body not accepted
   (415 code). Accept-Patch returned with acceptable values. (John
   Rouillard)
+- issue2551074 - In "responsive" template: click on hide comment leads
+  to a red error msg. (Report by Ludwig Reiter; fix John Rouillard)
 
 Features:
 

doc/upgrading.txt

@@ -108,6 +108,33 @@ the `PySQLite <https://github.com/ghaering/pysqlite>`_ library has
 been removed in 2.5.0. Only the Python supplied sqlite3 library will
 be supported.
 
+Update responsive template _generic.404.html and query.item.html (recommended)
+------------------------------------------------------------------------------
+
+This only applies if your tracker is based on the responsive
+template. Check the TEMPLATE-INFO.txt file in your tracker
+home. The template name is the first component of the ``Name``
+field. For example a Name like::
+
+   Name: responsive-bugtracker
+
+is based on the responsive template. If the Name doesn't start with
+``responsive`` no changes are needed.
+
+The ``_generic.404.html`` and ``query.item.html`` templates will crash
+when displayed because a missing macro is called. Change::
+
+  <tal:block metal:use-macro="templates/page/macros/icing">
+
+to::
+
+  <tal:block metal:use-macro="templates/page/macros/frame">
+
+at the top of both files. The icing macro used in other tracker
+templates was renamed to frame in this tracker template.
+
+
+
 .. index:: Upgrading; 2.3.0 to 2.4.0
 
 Migrating from 2.3.0 to 2.4.0

share/roundup/templates/responsive/html/_generic.404.html

@@ -1,5 +1,5 @@
 <!-- dollarId: issue.item,v 1.4 2001/08/03 01:19:43 richard Exp dollar-->
-<tal:block metal:use-macro="templates/page/macros/icing">
+<tal:block metal:use-macro="templates/page/macros/frame">
   <title metal:fill-slot="head_title">
   Item Not Found
   </title>

share/roundup/templates/responsive/html/query.item.html

@@ -2,7 +2,7 @@
 <span tal:condition="context/is_view_ok" tal:replace="structure
       context/renderQueryForm" />
 <tal:block tal:condition="not:context/is_view_ok">
-  <tal:block metal:use-macro="templates/page/macros/icing">
+  <tal:block metal:use-macro="templates/page/macros/frame">
     <title metal:fill-slot="head_title">You can not view query</title>
     <tal:block metal:fill-slot="body_title">
       You can not view query.