Fix incorrect labelling of a change as a "new submission".

Author: Richard Jones

roundup/roundupdb.py

@@ -16,7 +16,7 @@
 # BASIS, AND THERE IS NO OBLIGATION WHATSOEVER TO PROVIDE MAINTENANCE,
 # SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS.
 #
-# $Id: roundupdb.py,v 1.133 2007-09-16 02:45:11 jpend Exp $
+# $Id: roundupdb.py,v 1.134 2007-11-04 06:11:18 richard Exp $
 
 """Extending hyperdb with types specific to issue-tracking.
 """
@@ -304,8 +304,7 @@ def send_message(self, nodeid, msgid, note, sendto, from_address=None,
 
         # add author information
         if authid and self.db.config.MAIL_ADD_AUTHORINFO:
-            if len(self.get(nodeid,'messages')) == 1:
-                
+            if msgid and len(self.get(nodeid, 'messages')) == 1:
                 m.append(_("New submission from %(authname)s%(authaddr)s:")
                     % locals())
             elif msgid:

test/test_mailgw.py

@@ -8,7 +8,7 @@
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 #
-# $Id: test_mailgw.py,v 1.89 2007-09-12 21:11:14 jpend Exp $
+# $Id: test_mailgw.py,v 1.90 2007-11-04 06:11:19 richard Exp $
 
 # TODO: test bcc
 
@@ -447,14 +447,13 @@ def testPropertyChangeOnly(self):
         self.db.commit()
         self.db.issue.nosymessage('1', None, oldvalues)
 
-
         new_mail = ""
         for line in self._get_mail().split("\n"):
             if "Message-Id: " in line:
                 continue
             if "Date: " in line:
                 continue
-            new_mail+=line+"\n"
+            new_mail += line+"\n"
 
         self.compareMessages(new_mail, """
 FROM: [email protected]
@@ -482,7 +481,7 @@ def testPropertyChangeOnly(self):
 <http://tracker.example/cgi-bin/roundup.cgi/bugs/issue1>
 _______________________________________________________________________
 """)
-        
+
 
     #
     # FOLLOWUP TITLE MATCH