issue2550763 Strip whitespace from Multilink values after + or -.

Diagnosis, patch developed by W. Trevor King. Test heavily modified by
John Rouillard.

The goal is to make:

  Subject: [issue23455] ... [ keyword =+ Foo,Foo Zot ; nosy =+ mary ]

act like:

  Subject: [issue23455] ... [ keyword =+Foo,Foo Zot; nosy =+mary]

Without the patch " Foo" is not recognized.

Author: rouilj

CHANGES.txt

@@ -63,6 +63,9 @@ Fixed:
 - Update documentation of some existing property attributes (like
   'do_journal' for Link/Multilink properties), this also adds missing
   documentation for issue1444214. (Ralf Schlatterbeck)
+- issue2550763 Strip whitespace from Multilink values after + or -.
+  (W. Trevor King) Test heavily modified by John Rouillard. (applied
+  by John Rouillard)
 
 2016-01-11: 1.5.1
 

roundup/hyperdb.py

@@ -232,10 +232,10 @@ def from_raw(self, value, db, klass, propname, itemid, **kw):
             remove = 0
             if item.startswith('-'):
                 remove = 1
-                item = item[1:]
+                item = item[1:].strip()
                 do_set = 0
             elif item.startswith('+'):
-                item = item[1:]
+                item = item[1:].strip()
                 do_set = 0
 
             # look up the value

test/test_mailgw.py

@@ -3046,6 +3046,56 @@ def testSecurityMessagePermissionContent(self):
 nosy: +mary
 status: unread -> chatting
 
+_______________________________________________________________________
+Roundup issue tracker <[email protected]>
+<http://tracker.example/cgi-bin/roundup.cgi/bugs/issue1>
+_______________________________________________________________________
+''')
+
+    def testSpacesAroundMultilinkPropertyValue(self):
+        self.db.keyword.create(name='Foo')
+        self.db.keyword.create(name='Bar')
+        self.db.keyword.create(name='Baz This')
+        nodeid1 = self.doNewIssue()
+        nodeid2 = self._handle_mail('''Content-Type: text/plain;
+  charset="iso-8859-1"
+From: "Bork, Chef" <[email protected]>
+To: [email protected]
+Message-Id: <followup_dummy_id>
+In-Reply-To: <dummy_test_message_id>
+Subject: [issue1] set keyword [ keyword =+ Foo,Baz This ; nosy =+ mary ]
+
+Set the Foo and Baz This keywords along with mary for nosy.
+''')
+        assert os.path.exists(SENDMAILDEBUG)
+        self.compareMessages(self._get_mail(),
+'''FROM: [email protected]
+TO: [email protected], [email protected]
+Content-Type: text/plain; charset="utf-8"
+Subject: [issue1] set keyword
+To: [email protected], [email protected]
+From: "Bork, Chef" <[email protected]>
+Reply-To: Roundup issue tracker
+ <[email protected]>
+MIME-Version: 1.0
+Message-Id: <followup_dummy_id>
+In-Reply-To: <dummy_test_message_id>
+X-Roundup-Name: Roundup issue tracker
+X-Roundup-Loop: hello
+X-Roundup-Issue-Status: chatting
+X-Roundup-Issue-keyword: Foo, Baz This
+Content-Transfer-Encoding: quoted-printable
+
+Bork, Chef <[email protected]> added the comment:
+
+Set the Foo and Baz This keywords along with mary for nosy.
+
+----------
+keyword: +Baz This, Foo
+nosy: +mary
+status: unread -> chatting
+title: Testing... -> set keyword
+
 _______________________________________________________________________
 Roundup issue tracker <[email protected]>
 <http://tracker.example/cgi-bin/roundup.cgi/bugs/issue1>