more tweakage of help display and style issues

Richard Jones · Richard Jones · commit 8e3297d89fb6 · 2002-09-09T04:43:10.000Z
diff --git a/TODO.txt b/TODO.txt
@@ -51,6 +51,7 @@ pending web: rewritten documentation (can come after the beta though so stuff
              is settled) ... including relevant file names in customisation doc
 pending admin: have roundup-admin "set" command be applicable to all items
                in a class
+pending dist: include the HTML in docs
 
 bug: request.url is incorrect in cgi-bin environments
 bug: query editing not translated to new templating
diff --git a/doc/installation.txt b/doc/installation.txt
@@ -2,7 +2,7 @@
 Installing Roundup
 ==================
 
-:Version: $Revision: 1.20 $
+:Version: $Revision: 1.21 $
 
 .. contents::
 
@@ -180,6 +180,10 @@ My group now looks like this::
 
      support:*:1002:jblaine,samh,geezer,mail,apache
 
+The instance "db" directory should be chmod'ed g+sw so that the group can
+write to the database, and any new files created in the database will be owned
+by the group.
+
 An alternative to the above is to create a new user who has the sole
 responsibility of running roundup. This user:
 
@@ -189,7 +193,6 @@ responsibility of running roundup. This user:
 4. optionally has no login password so that nobody but the "root" user
    may actually login and play with the roundup setup.
 
-
 Internet Setup
 ~~~~~~~~~~~~~~
 
diff --git a/roundup/cgi/client.py b/roundup/cgi/client.py
@@ -1,4 +1,4 @@
-# $Id: client.py,v 1.22 2002-09-09 03:20:09 richard Exp $
+# $Id: client.py,v 1.23 2002-09-09 04:43:10 richard Exp $
 
 __doc__ = """
 WWW request handler (also used in the stand-alone server).
@@ -13,7 +13,7 @@
 from roundup.cgi.templating import getTemplate, HTMLRequest, NoTemplate
 from roundup.cgi import cgitb
 
-from PageTemplates import PageTemplate
+from roundup.cgi.PageTemplates import PageTemplate
 
 class Unauthorised(ValueError):
     pass
@@ -285,7 +285,6 @@ def determine_context(self, dre=re.compile(r'([^\d]+)(\d+)')):
         if self.form.has_key(':template'):
             self.template = self.form[':template'].value
 
-
         # see if we were passed in a message
         if self.form.has_key(':ok_message'):
             self.ok_message.append(self.form[':ok_message'].value)
diff --git a/roundup/cgi/templating.py b/roundup/cgi/templating.py
@@ -168,7 +168,8 @@ def render(self, client, classname, request, **options):
         __traceback_supplement__ = (PageTemplate.PageTemplateTracebackSupplement, self)
 
         if self._v_errors:
-            raise PTRuntimeError, 'Page Template %s has errors.' % self.id
+            raise PageTemplate.PTRuntimeError, \
+                'Page Template %s has errors.' % self.id
 
         # figure the context
         classname = classname or client.classname
diff --git a/roundup/templates/classic/html/_generic.help b/roundup/templates/classic/html/_generic.help
@@ -1,11 +1,15 @@
-<table tal:define="props python:request.form['properties'].value.split(',')"
-       border=1 cellspacing=0 cellpadding=2>
-<tr>
- <th align=left tal:repeat="prop props" tal:content="prop"></th>
-</tr>
-<tr tal:repeat="item klass/list">
- <td align="left" valign="top" tal:repeat="prop props"
-     tal:content="python:item[prop]"></td>
+<html>
+<head>
+<link rel="stylesheet" type="text/css" href="_file/style.css">
+</head>
+<body class="body" marginwidth="0" marginheight="0">
+
+<table class="classhelp"
+       tal:define="props python:request.form['properties'].value.split(',')">
+<tr><th tal:repeat="prop props" tal:content="prop"></th></tr>
+<tr tal:repeat="item context/list">
+ <td tal:repeat="prop props" tal:content="python:item[prop]"></td>
 </tr>
 </table>
 
+</body>
diff --git a/roundup/templates/classic/html/issue.item b/roundup/templates/classic/html/issue.item
@@ -2,6 +2,7 @@
 <form method="POST" onSubmit="return submit_once()"
       enctype="multipart/form-data">
 
+<input type="hidden" name=":template" value="item">
 <input type="hidden" name=":required" value="title">
 
 <table class="form">
@@ -35,9 +36,7 @@
 
 <tr>
  <th nowrap>Assigned To</th>
- <td tal:content="structure context/assignedto/menu">
-  assignedto menu
- </td>
+ <td tal:content="structure context/assignedto/menu">assignedto menu</td>
  <td>&nbsp;</td>
  <td>&nbsp;</td>
 </tr>
@@ -68,14 +67,16 @@ changed <b>${context/activity}</b>.">activity info</span>
 
 <tal:block tal:condition="context/id">
  <table class="messages" tal:condition="context/messages">
-  <tr><th colspan=2 class="header">Messages</th></tr>
+  <tr><th colspan=3 class="header">Messages</th></tr>
   <tal:block tal:repeat="msg context/messages/reverse">
    <tr>
+    <th><a tal:attributes="href string:msg${msg/id}"
+           tal:content="string:msg${msg/id}"></a></th>
     <th tal:content="string:Author: ${msg/author}">author</th>
     <th tal:content="string:Date: ${msg/date}">date</th>
    </tr>
    <tr>
-    <td colspan="2"><pre tal:content="msg/content">content</pre></td>
+    <td colspan="3"><pre tal:content="msg/content">content</pre></td>
    </tr>
   </tal:block>
  </table>
diff --git a/roundup/templates/classic/html/page b/roundup/templates/classic/html/page
@@ -10,7 +10,7 @@
 </head>
 <body class="body" marginwidth="0" marginheight="0">
 
-<table border=0 cellspacing=0 cellpadding=0>
+<table class="body">
 
 <tr>
  <td class="page-header-left">&nbsp;</td>
diff --git a/roundup/templates/classic/html/style.css b/roundup/templates/classic/html/style.css
@@ -1,18 +1,25 @@
 /* main page styles */
-.body {
+body.body {
   font-family: sans-serif, Arial, Helvetica;
   color: #333333;
 }
 a:hover { text-decoration: underline; }
 a:link { text-decoration: none; }
 a { text-decoration: none; }
 
-.page-header-left {
+table.body {
+  border: 0;
+  padding: 0;
+  border-spacing: 0px;
+  border-collapse: separate;
+}
+
+td.page-header-left {
   background-color: #cccc88;
   padding: 5px;
 }
 
-.page-header-top {
+td.page-header-top {
   background-color: #cccc88;
   border-bottom: 1px solid #dddd99;
   padding: 5px;
@@ -81,14 +88,17 @@ table.form td.optional {
   font-weight: bold;
   font-style: italic;
   color: #333333;
+  empty-cells: show;
 }
 
 table.form td {
   color: #333333;
+  empty-cells: show;
 }
 
 table.form td.html {
   color: #777777;
+  empty-cells: show;
 }
 
 /* style for lists */
@@ -124,20 +134,24 @@ table.list td {
 }
 
 table.list td.normal {
+  empty-cells: show;
 }
 
 table.list td.alt {
   background-color: #efefef;
+  empty-cells: show;
 }
 
 table.list td:first-child {
   border-left: 1px solid #404070;
   border-right: 1px solid #404070;
+  empty-cells: show;
 }
 
 table.list th:first-child {
   border-left: 1px solid #404070;
   border-right: 1px solid #404070;
+  empty-cells: show;
 }
 
 
@@ -168,6 +182,7 @@ table.messages td {
   border-top: 1px solid #afafaf;
   border-bottom: 1px solid #afafaf;
   color: black;
+  empty-cells: show;
 }
 
 /* style for file displays */
@@ -193,6 +208,7 @@ table.files th {
 
 table.files td {
   font-family: monospace;
+  empty-cells: show;
 }
 
 /* style for history displays */
@@ -221,6 +237,7 @@ table.history th {
 table.history td {
   font-size: 90%;
   vertical-align: top;
+  empty-cells: show;
 }
 
 /* style for "other" displays */
@@ -265,3 +282,26 @@ table.classlist th {
   text-align: left;
 }
 
+
+/* style for class help display */
+table.classhelp {
+  border-spacing: 0px;
+  border-collapse: separate;
+  width: 100%;
+}
+
+table.classhelp th {
+  font-weight: bold;
+  text-align: left;
+  color: #707040;
+}
+
+table.classhelp td {
+  padding: 2 2 2 2;
+  border: 1px solid black;
+  text-align: left;
+  vertical-align: top;
+  empty-cells: show;
+}
+
+
