Python 2 and 3 support. Convert Exception into BaseException in core code.

Author: rouilj

roundup/cgi/exceptions.py

@@ -6,7 +6,7 @@
 from roundup.exceptions import LoginError, Unauthorised
 import cgi
 
-class HTTPException(Exception):
+class HTTPException(BaseException):
     pass
 
 class Redirect(HTTPException):
@@ -18,7 +18,7 @@ class NotFound(HTTPException):
 class NotModified(HTTPException):
     pass
 
-class DetectorError(Exception):
+class DetectorError(BaseException):
     """Raised when a detector throws an exception.
 Contains details of the exception."""
     def __init__(self, subject, html, txt):
@@ -38,13 +38,13 @@ class FormError(ValueError):
     """
     pass
 
-class SendFile(Exception):
+class SendFile(BaseException):
     """Send a file from the database."""
 
-class SendStaticFile(Exception):
+class SendStaticFile(BaseException):
     """Send a static file from the instance html directory."""
 
-class SeriousError(Exception):
+class SeriousError(BaseException):
     """Raised when we can't reasonably display an error message on a
     templated page.
 

roundup/cgi/templating.py

@@ -109,10 +109,10 @@ def anti_csrf_nonce(self, client, lifetime=None):
 
 ### templating
 
-class NoTemplate(Exception):
+class NoTemplate(BaseException):
     pass
 
-class Unauthorised(Exception):
+class Unauthorised(BaseException):
     def __init__(self, action, klass, translator=None):
         self.action = action
         self.klass = klass

roundup/configuration.py

@@ -22,7 +22,7 @@
 
 ### Exceptions
 
-class ConfigurationError(Exception):
+class ConfigurationError(BaseException):
     pass
 
 class NoConfigError(ConfigurationError):

roundup/exceptions.py

@@ -3,13 +3,13 @@
 
 __docformat__ = 'restructuredtext'
 
-class LoginError(Exception):
+class LoginError(BaseException):
     pass
 
-class Unauthorised(Exception):
+class Unauthorised(BaseException):
     pass
 
-class Reject(Exception):
+class Reject(BaseException):
     """An auditor may raise this exception when the current create or set
     operation should be stopped.
 

roundup/instance.py

@@ -257,7 +257,7 @@ def registerAction(self, name, action):
     def registerUtil(self, name, function):
         self.templating_utils[name] = function
 
-class TrackerError(Exception):
+class TrackerError(BaseException):
     pass
 
 

roundup/mailgw.py

@@ -119,15 +119,15 @@ class MailGWError(ValueError):
 class MailUsageError(ValueError):
     pass
 
-class MailUsageHelp(Exception):
+class MailUsageHelp(BaseException):
     """ We need to send the help message to the user. """
     pass
 
-class Unauthorized(Exception):
+class Unauthorized(BaseException):
     """ Access denied """
     pass
 
-class IgnoreMessage(Exception):
+class IgnoreMessage(BaseException):
     """ A general class of message that we should ignore. """
     pass
 class IgnoreBulk(IgnoreMessage):