Skip to content

Commit 8bee3a7

Browse files
committed
update Anonymous Create user to Register user permissions
the devel and responsive tracker templates still had the old Create user permissions for the anonymous user. Replace with the Regiter permission that has been the standard since 1.4.11 maybe. Also update references to Create permission in comment for the Email Access permission for anon user.
1 parent 2dd1a00 commit 8bee3a7

File tree

7 files changed

+29
-9
lines changed

7 files changed

+29
-9
lines changed

CHANGES.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,8 @@ Fixed:
6363
different files).
6464
- Fix Traceback when a numeric order attribute is empty (Ralf
6565
Schlatterbeck)
66+
- Update some template schema files to assign Register permissions for the
67+
Anonymous user. Replaces the old Create permission. (John Rouillard)
6668

6769
Features:
6870

doc/upgrading.txt

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,8 @@ You can then merge any local comments from the tracker's
6666
``config.ini`` to ``newconfig.ini`` and replace
6767
``config.ini`` with ``newconfig.ini``.
6868

69-
Using the roundup-mailgw script
70-
-------------------------------
69+
Using the roundup-mailgw script (required)
70+
------------------------------------------
7171

7272
In previous versions the roundup-mailgw script had a ``-C`` (or
7373
``--class``) option for specifying a class to be used with ``-S`` (or
@@ -96,6 +96,24 @@ versions).
9696
If you do not use the ``-C`` (or ``--class``) option in your current
9797
setup of mailgw you don't need to change anything.
9898

99+
Replace Create User permission for Anonymous with Register (required)
100+
---------------------------------------------------------------------
101+
102+
Check your trackers schema.py. If you have the following code::
103+
104+
db.security.addPermissionToRole('Anonymous', 'Create', 'user')
105+
106+
after the permission for Anonymous 'Email Access', change it to::
107+
108+
db.security.addPermissionToRole('Anonymous', 'Register', 'user')
109+
110+
The comment for Anonymous 'Email Access' may refer to Create. Change
111+
it to refer to Register.
112+
113+
This will be an issue if you used the devel or responsive tracker
114+
templates. If you used a classic, minimal or jinja2 template the
115+
permission change (but not the comment change) should be done already.
116+
99117
Rdbms version change from 7 to 8 (required)
100118
-------------------------------------------
101119

share/roundup/templates/classic/schema.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ def edit_query(db, userid, itemid):
160160

161161
# Let anonymous users access the email interface (note that this implies
162162
# that they will be registered automatically, hence they will need the
163-
# "Create" user Permission below)
163+
# "Register" user Permission below)
164164
# This is disabled by default to stop spam from auto-registering users on
165165
# public trackers.
166166
#db.security.addPermissionToRole('Anonymous', 'Email Access')

share/roundup/templates/devel/schema.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -363,15 +363,15 @@ def edit_query(db, userid, itemid):
363363

364364
# Let anonymous users access the email interface (note that this implies
365365
# that they will be registered automatically, hence they will need the
366-
# "Create" user Permission below)
366+
# "Register" user Permission below)
367367
# This is disabled by default to stop spam from auto-registering users on
368368
# public trackers.
369369
#db.security.addPermissionToRole('Anonymous', 'Email Access')
370370

371371
# Assign the appropriate permissions to the anonymous user's Anonymous
372372
# Role. Choices here are:
373373
# - Allow anonymous users to register
374-
db.security.addPermissionToRole('Anonymous', 'Create', 'user')
374+
db.security.addPermissionToRole('Anonymous', 'Register', 'user')
375375

376376
# Allow anonymous users access to view issues (and the related, linked
377377
# information).

share/roundup/templates/jinja2/schema.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ def edit_query(db, userid, itemid):
160160

161161
# Let anonymous users access the email interface (note that this implies
162162
# that they will be registered automatically, hence they will need the
163-
# "Create" user Permission below)
163+
# "Register" user Permission below)
164164
# This is disabled by default to stop spam from auto-registering users on
165165
# public trackers.
166166
#db.security.addPermissionToRole('Anonymous', 'Email Access')

share/roundup/templates/minimal/schema.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ def own_record(db, userid, itemid):
6161

6262
# Let anonymous users access the email interface (note that this implies
6363
# that they will be registered automatically, hence they will need the
64-
# "Create" user Permission below)
64+
# "Register" user Permission below)
6565
db.security.addPermissionToRole('Anonymous', 'Email Access')
6666

6767
# Assign the appropriate permissions to the anonymous user's

share/roundup/templates/responsive/schema.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -363,15 +363,15 @@ def edit_query(db, userid, itemid):
363363

364364
# Let anonymous users access the email interface (note that this implies
365365
# that they will be registered automatically, hence they will need the
366-
# "Create" user Permission below)
366+
# "Register" user Permission below)
367367
# This is disabled by default to stop spam from auto-registering users on
368368
# public trackers.
369369
#db.security.addPermissionToRole('Anonymous', 'Email Access')
370370

371371
# Assign the appropriate permissions to the anonymous user's Anonymous
372372
# Role. Choices here are:
373373
# - Allow anonymous users to register
374-
db.security.addPermissionToRole('Anonymous', 'Create', 'user')
374+
db.security.addPermissionToRole('Anonymous', 'Register', 'user')
375375

376376
# Allow anonymous users access to view issues (and the related, linked
377377
# information).

0 commit comments

Comments
 (0)