fix the fix for ensuring POST

Author: Richard Jones

roundup/cgi/actions.py

@@ -105,7 +105,7 @@ def handle(self):
         """Retire the context item."""
         # ensure modification comes via POST
         if self.client.env['REQUEST_METHOD'] != 'POST':
-            self.client.error_message.append(self._('Invalid request'))
+            raise roundup.exceptions.Reject(self._('Invalid request'))
 
         # if we want to view the index template now, then unset the itemid
         # context info (a special-case for retire actions on the index page)
@@ -284,7 +284,7 @@ def handle(self):
         """
         # ensure modification comes via POST
         if self.client.env['REQUEST_METHOD'] != 'POST':
-            self.client.error_message.append(self._('Invalid request'))
+            raise roundup.exceptions.Reject(self._('Invalid request'))
 
         # figure the properties list for the class
         cl = self.db.classes[self.classname]
@@ -587,7 +587,7 @@ def handle(self):
         """
         # ensure modification comes via POST
         if self.client.env['REQUEST_METHOD'] != 'POST':
-            self.client.error_message.append(self._('Invalid request'))
+            raise roundup.exceptions.Reject(self._('Invalid request'))
 
         user_activity = self.lastUserActivity()
         if user_activity:
@@ -633,7 +633,7 @@ def handle(self):
         '''
         # ensure modification comes via POST
         if self.client.env['REQUEST_METHOD'] != 'POST':
-            self.client.error_message.append(self._('Invalid request'))
+            raise roundup.exceptions.Reject(self._('Invalid request'))
 
         # parse the props from the form
         try:
@@ -819,7 +819,7 @@ def handle(self):
         """
         # ensure modification comes via POST
         if self.client.env['REQUEST_METHOD'] != 'POST':
-            self.client.error_message.append(self._('Invalid request'))
+            raise roundup.exceptions.Reject(self._('Invalid request'))
 
         # parse the props from the form
         try:
@@ -937,7 +937,7 @@ def handle(self):
         """
         # ensure modification comes via POST
         if self.client.env['REQUEST_METHOD'] != 'POST':
-            self.client.error_message.append(self._('Invalid request'))
+            raise roundup.exceptions.Reject(self._('Invalid request'))
 
         # we need the username at a minimum
         if not self.form.has_key('__login_name'):
@@ -1086,11 +1086,11 @@ def execute_cgi(self):
     def permission(self, args):
         """Raise Unauthorised if the current user is not allowed to execute
         this action. Users may override this method."""
-        
+
         pass
 
     def handle(self, args):
-        
+
         raise NotImplementedError
 
 # vim: set filetype=python sts=4 sw=4 et si :