Don't display submit button with readoly use of _generic.item.html

_generic.item.html in all templates except jinja2 displays the
submit button even when the user has no edit rights.

Check for is_edit_ok before emitting the submit button.

The jinja2 template doesn't have an _generic.item.html template.

Author: rouilj

CHANGES.txt

@@ -110,6 +110,8 @@ Fixed:
 - make setup.py install the Zope and wsgi.py frontends under
   share/frontends. This matches the install fo the cgi-bin/roundup.cgi
   frontend. (John Rouillard)
+- prevent submit button from showing up when using _generic.item.html
+  if the user doesn't have edit permissions
 
 Features:
 

doc/upgrading.txt

@@ -228,6 +228,26 @@ If you use this and it works for you please followup with an email to
 the roundup-users at lists.sourceforge.net mailing list so we can
 enable it by default in a future release.
 
+
+Hide submit button during readonly use of _generic.item.html (optional)
+-----------------------------------------------------------------------
+
+The submit button in _generic.item.html always shows up even when the
+user doesn't have edit perms. Change the ``context/submit`` html to
+read::
+
+   <td colspan=3 tal:content="structure context/submit"
+       tal:condition="context/is_edit_ok">
+
+in your TAL based templates. The ``jinja2`` based templates are
+missing this file, but if you implemented one you want to surround the
+jinja2 code with::
+
+  {% if context.is_view_ok() %}
+    <submit button code here>
+  {% endif %}
+
+
 Migrating from 2.0.0 to 2.1.0
 =============================
 

share/roundup/templates/classic/html/_generic.item.html

@@ -36,7 +36,8 @@
 </tr>
 <tr>
  <td>&nbsp;</td>
- <td colspan=3 tal:content="structure context/submit">
+ <td colspan=3 tal:content="structure context/submit"
+     tal:condition="context/is_edit_ok">
   submit button will go here
  </td>
 </tr>

share/roundup/templates/devel/html/_generic.item.html

@@ -36,7 +36,8 @@
 </tr>
 <tr>
  <td>&nbsp;</td>
- <td colspan=3 tal:content="structure context/submit">
+ <td colspan=3 tal:content="structure context/submit"
+     tal:condition="context/is_edit_ok">
   submit button will go here
  </td>
 </tr>

share/roundup/templates/minimal/html/_generic.item.html

@@ -36,7 +36,8 @@
 </tr>
 <tr>
  <td>&nbsp;</td>
- <td colspan=3 tal:content="structure context/submit">
+ <td colspan=3 tal:content="structure context/submit"
+     tal:condition="context/is_edit_ok">
   submit button will go here
  </td>
 </tr>

share/roundup/templates/responsive/html/_generic.item.html

@@ -36,7 +36,8 @@
 </tr>
 <tr>
  <td>&nbsp;</td>
- <td colspan=3 tal:content="structure context/submit">
+ <td colspan=3 tal:content="structure context/submit"
+     tal:condition="context/is_edit_ok">
   submit button will go here
  </td>
 </tr>