Skip to content

Commit 811415d

Browse files
committed
build: remove python 2.x directions; other notes/clarifications
1 parent 89f7a4d commit 811415d

File tree

1 file changed

+17
-3
lines changed

1 file changed

+17
-3
lines changed

RELEASE.txt

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -147,10 +147,10 @@ Roundup release checklist:
147147

148148
11. Unpack the new tarball created in dist/roundup-<version>.tar.gz
149149
file in /tmp then
150-
a) run tests using installed pytest run under python2 and
151-
python3. (python2 -m pytest test/; python3 -m pytest test/)
150+
a) run tests using installed pytest run under
151+
python3. (python3 -m pytest test/)
152152
b) demo.py
153-
with all available Python versions.
153+
with all available Python 3 versions.
154154
11a. (TBD how to test wheel binary distribution before uploading.)
155155

156156
11b. Generate GPG signature file
@@ -269,12 +269,26 @@ Roundup release checklist:
269269
You may need to explicitly update/refresh the scanners with:
270270
"docker pull anchore/grype:latest" and similarly for
271271
aquasec/trivy if used.
272+
273+
Note that some security issues may show up. If they are in the
274+
underlying OS package we can't do anything but make sure the
275+
latest python:3-alpine package is used to build the image. Look
276+
at the index digest on the image release page and compare it to
277+
the sha256 at the top of the Dockerfile.
278+
272279
17d. test roundup in demo mode:
273280

274281
docker run -it --rm -p 8917:8080 \
275282
-v $PWD/tracker:/usr/src/app/tracker \
276283
rounduptracker/roundup:2.4.0 demo
277284

285+
FIXME: right now the external port number (8917) in the above
286+
command is hardcoded in DOCKER. It can be overridden usng
287+
PORT_8080=9017 for example. However the host is always
288+
localhost. Consider replacing PORT_8080 with ORIGIN="host:port"
289+
or ORIGIN="port" so that the web URL can be made correct when
290+
running docker on a remote server.
291+
278292
17e. push to DockerHub login (login using 'docker login <username>'
279293
first and user must be member of rounduptracker org with ability
280294
to publish). Replace -N with the release number (e.g. -1, -2, -3...)

0 commit comments

Comments
 (0)