Skip to content

Commit 803f82f

Browse files
author
Alexander Smishlajev
committed
get_backend_name() is a lengthy thing (file I/O).
since we are not going to do backend switching at runtime, compute the backend once in __init__().
1 parent 86f4338 commit 803f82f

File tree

1 file changed

+5
-11
lines changed

1 file changed

+5
-11
lines changed

roundup/instance.py

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
# BASIS, AND THERE IS NO OBLIGATION WHATSOEVER TO PROVIDE MAINTENANCE,
1616
# SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS.
1717
#
18-
# $Id: instance.py,v 1.28 2004-11-03 01:34:21 richard Exp $
18+
# $Id: instance.py,v 1.29 2004-11-10 08:05:21 a1s Exp $
1919

2020
'''Tracker handling (open tracker).
2121
@@ -50,6 +50,7 @@ def __init__(self, tracker_home, optimize=0):
5050
self.templating_utils = {}
5151
self.load_interfaces()
5252
self.templates = templating.Templates(self.config["TEMPLATES"])
53+
self.backend = backends.get_backend(self.get_backend_name())
5354
if self.optimize:
5455
self.templates.precompileTemplates()
5556

@@ -60,11 +61,8 @@ def get_backend_name(self):
6061
f.close()
6162
return name
6263

63-
def get_backend(self):
64-
return backends.get_backend(self.get_backend_name())
65-
6664
def open(self, name=None):
67-
backend = self.get_backend()
65+
backend = self.backend
6866
vars = {
6967
'Class': backend.Class,
7068
'FileClass': backend.FileClass,
@@ -114,12 +112,10 @@ def init(self, adminpw):
114112
db.close()
115113

116114
def exists(self):
117-
backend = self.get_backend()
118-
return backend.db_exists(self.config)
115+
return self.backend.db_exists(self.config)
119116

120117
def nuke(self):
121-
backend = self.get_backend()
122-
backend.db_nuke(self.config)
118+
self.backend.db_nuke(self.config)
123119

124120
def _load_python(self, file, vars):
125121
file = os.path.join(self.tracker_home, file)
@@ -182,8 +178,6 @@ def open(self, tracker_home, optimize=0):
182178

183179
# load and apply the config
184180
tracker.config = configuration.CoreConfig(tracker_home)
185-
# FIXME! dbinit does "import config".
186-
# What would be the upgrade plan for existing trackers?
187181
tracker.dbinit.config = tracker.config
188182

189183
tracker.optimize = optimize

0 commit comments

Comments
 (0)