Skip to content

Commit 7e6f466

Browse files
committed
Remove length checks. We check list content explicitly.
So the length checks are redundant.
1 parent f2ae100 commit 7e6f466

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

test/rest_common.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2973,7 +2973,6 @@ def testPatchAdd(self):
29732973
results = self.server.get_element('issue', issue_id, self.terse_form)
29742974
results = results['data']
29752975
self.assertEqual(self.dummy_client.response_code, 200)
2976-
self.assertEqual(len(results['attributes']['nosy']), 2)
29772976
self.assertListEqual(results['attributes']['nosy'], ['1', '2'])
29782977

29792978
etag = calculate_etag(self.db.issue.getnode(issue_id),
@@ -2991,9 +2990,9 @@ def testPatchAdd(self):
29912990
results = self.server.get_element('issue', issue_id, self.terse_form)
29922991
results = results['data']
29932992
self.assertEqual(self.dummy_client.response_code, 200)
2994-
self.assertEqual(len(results['attributes']['nosy']), 3)
29952993
self.assertListEqual(results['attributes']['nosy'], ['1', '2', '3'])
29962994

2995+
29972996
# patch with no new_val/data
29982997
etag = calculate_etag(self.db.issue.getnode(issue_id),
29992998
self.db.config['WEB_SECRET_KEY'])
@@ -3010,7 +3009,6 @@ def testPatchAdd(self):
30103009
results = self.server.get_element('issue', issue_id, self.terse_form)
30113010
results = results['data']
30123011
self.assertEqual(self.dummy_client.response_code, 200)
3013-
self.assertEqual(len(results['attributes']['nosy']), 3)
30143012
self.assertListEqual(results['attributes']['nosy'], ['1', '2', '3'])
30153013

30163014
# patch invalid property
@@ -3057,7 +3055,6 @@ def testPatchReplace(self):
30573055
results = results['data']
30583056
self.assertEqual(self.dummy_client.response_code, 200)
30593057
self.assertEqual(results['attributes']['status'], '1')
3060-
self.assertEqual(len(results['attributes']['nosy']), 1)
30613058
self.assertListEqual(results['attributes']['nosy'], ['1'])
30623059

30633060
# replace userid 2 to the nosy list and status = 3
@@ -3077,7 +3074,6 @@ def testPatchReplace(self):
30773074
results = results['data']
30783075
self.assertEqual(self.dummy_client.response_code, 200)
30793076
self.assertEqual(results['attributes']['status'], '3')
3080-
self.assertEqual(len(results['attributes']['nosy']), 1)
30813077
self.assertListEqual(results['attributes']['nosy'], ['2'])
30823078

30833079
# replace status = 2 using status attribute

0 commit comments

Comments
 (0)