Run coveralls push only if all builds succeed.

I wanted to run the coveralls push even if there was only one
successful run. So I forced it to run even if there was an error in
one of the paralle workflows. However coveralls push was succeeding
and setting the job status to ok even though I want it to be failing.

It appears I can't get what I want in an easy manner so don't upload
any data to coveralls if any CI test job fails.

I will still have the successful jobs uploaded to codecov at least.

Author: rouilj

.github/workflows/ci-test.yml

@@ -34,7 +34,7 @@ jobs:
 
     # run the finalizer for coveralls even if one or more
     # matrix runs fail.
-    continue-on-error: true
+    # continue-on-error: true
 
     #runs-on: ubuntu-latest
     # use below if running on multiple OS's.
@@ -260,7 +260,7 @@ jobs:
       #         -f scripts/Docker/Dockerfile . 
 
 
-  # in parallel build codecov requires a finish step
+  # in parallel build coveralls requires a finish step
   finish:
     needs: test
     runs-on: ubuntu-latest