index args URL generation broken in .10 [SF#1096027]

Author: Richard Jones

CHANGES.txt

@@ -59,8 +59,12 @@ Fixed:
 - removed safeget() from the API (sf bug 994750)
 - demo tracker is always set up on localhost (sf bug 1049101)
 
+2004-10-06 0.7.11
+Fixed:
+- index args URL generation broken in .10 (sf bug 1096027)
+
 
-2004-10-?? 0.7.10
+2004-10-04 0.7.10
 Fixed:
 - reset ID counters if the database is cleared (thanks William)
 - apply IE caching "fix" to automatically serve up all pages expired

roundup/cgi/templating.py

@@ -2073,15 +2073,16 @@ def indexargs_url(self, url, args):
 
         # finally, the remainder of the filter args in the request
         props = self.client.db.getclass(self.classname).getprops()
+        q = urllib.quote
         for k,v in self.filterspec.items():
             if not args.has_key(k):
                 if type(v) == type([]):
                     if isinstance(props[k], hyperdb.String):
-                        l.append(s%(k, ' '.join(v)))
+                        l.append('%s=%s'%(k, '%20'.join([q(i) for i in v])))
                     else:
-                        l.append(s%(k, ','.join(v)))
+                        l.append('%s=%s'%(k, ','.join([q(i) for i in v])))
                 else:
-                    l.append('%s=%s'%(k, v))
+                    l.append('%s=%s'%(k, q(v)))
         return '%s?%s'%(url, '&'.join(l))
     indexargs_href = indexargs_url