Skip to content

Commit 7aabb30

Browse files
author
Richard Jones
committed
backport from HEAD
1 parent 841a9cc commit 7aabb30

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

CHANGES.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ Fixed:
1111
- fixed content-type when templates are serving up xml (thanks Godefroid
1212
Chapelle)
1313
- fixed IE double-submit when it shouldn't (sf bug 842254)
14+
- fixed check for JS pop()/push() to make more general (sf bug 877504)
1415

1516

1617
2003-12-17 0.6.4

templates/classic/html/help_controls.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,11 @@ function push() {
3535
}
3636
}
3737

38-
// add the pop() and push() method to Array prototype for old IE browser
39-
if (bName() == 1 && bVer() >= 5.5);
40-
else {
38+
// add the pop() and push() method to Array if they're not there
39+
if (!Array.prototype.pop) {
4140
Array.prototype.pop = pop;
41+
}
42+
if (!Array.prototype.push) {
4243
Array.prototype.push = push;
4344
}
4445

0 commit comments

Comments
 (0)