Lots of little fixes in this update:

- fixed Date.local()
- email quoted text stripping is controllable again [SF#650742]
- extract attachment name from content-disposition if name missing [SF#637278]
- removed FILTER_POSITION from bundled configs
- reverse message listing in issue display (reversion of recent change)
- bad entries for multilink editing in cgi don't traceback now [SF#640310]

Author: Richard Jones

CHANGES.txt

@@ -9,6 +9,13 @@ are given with the most recent entry first.
 - removed use of string/strop from TAL/TALInterpreter
 - handle KeyboardInterrupt nicely
 - fixed Date and Interval form value handling
+- fixed Date.local()
+- email quoted text stripping is controllable again (sf bug 650742)
+- extract attachment name from content-disposition if name is missing (sf
+  bug 637278)
+- removed FILTER_POSITION from bundled configs
+- reverse message listing in issue display (reversion of recent change)
+- bad entries for multilink editing in cgi don't traceback now (sf bug 640310)
 
 
 2002-11-07 0.5.2

TODO.txt

@@ -16,6 +16,8 @@ pending hyperdb   range searching of values (dates in particular).
                   [value, value, ...] implies "in"
 pending hyperdb   migrate "id" property to be Number type
 pending hyperdb   multilink sorting by length is dumb
+pending hyperdb   lastchangedby auto-property giving last user to change an
+                  item
 pending tracker   split instance.open() into open() and login()
 pending mailgw    allow commands (feature request #556996)
                   like "help", "dump issue123" (would send all info about
@@ -33,6 +35,8 @@ pending mailgw    Identification of users should have a configurable degree of
                   strictness (ie. turn off username==address matching)
 pending mailgw    Use in-reply-to for determining message lineage when subject
                   line lets us down
+pending mailgw    Allow different brackets delimiting [issueNNN] in Subject
+pending email     email sig could use a "remove me from this list"
 pending messages  Snarf the first whole sentence, or full first line of
                   messages for the summary - whichever is longer.
 pending project   switch to a Roundup instance for Roundup bug/feature tracking
@@ -56,14 +60,18 @@ pending web       allow multilink selections to select a "none" element to allow
 pending web       automagically link designators
 pending web       add checkbox-based removal/addition for multilink entries
                   (eg "add me"/"remove me" for nosy list)
-pending web       multilink item removal action (with retirement)
 pending web       search "refinement" - pre-fill the search page with the
                   current search parameters
 pending web       column-heading sort stuff isn't implemented
+pending web       multilink item removal action with retirement
+pending web       implement a python dict version of the form values
 
 active  web       UNIX init.d script for roundup-server
 bug     web       query editing isn't fully implemented
 bug     web       no testing for parsePropsFromForm
 active  web       revert to showing entire message in classic issue display
+bug     hyperdb   pysqlite and locks
+                  http://www.hwaci.com/sw/sqlite/c_interface.html
+bug     web       implement the request.url attribute?
 ======= ========= =============================================================
 

doc/customizing.txt

@@ -2,7 +2,7 @@
 Customising Roundup
 ===================
 
-:Version: $Revision: 1.63 $
+:Version: $Revision: 1.64 $
 
 .. This document borrows from the ZopeBook section on ZPT. The original is at:
    http://www.zope.org/Documentation/Books/ZopeBook/current/ZPT.stx
@@ -1486,6 +1486,10 @@ the "status" and "topic" properties, and the table includes columns for the
 Searching Views
 ---------------
 
+Note: if you add a new column to the ``:columns`` form variable potentials
+      then you will need to add the column to the `index view`_
+      template so it is actually displayed.
+
 This is one of the class context views. The template used is typically
 "*classname*.search". The form on this page should have "search" as its
 ``:action`` variable. The "search" action:
@@ -1515,7 +1519,6 @@ action are:
   template schema does not.
 
 
-
 Item Views
 ----------
 

roundup/__init__.py

@@ -15,7 +15,7 @@
 # BASIS, AND THERE IS NO OBLIGATION WHATSOEVER TO PROVIDE MAINTENANCE,
 # SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS.
 # 
-# $Id: __init__.py,v 1.16 2002-11-06 11:38:42 richard Exp $
+# $Id: __init__.py,v 1.17 2002-12-10 00:11:14 richard Exp $
 
 ''' Roundup - issue tracking for knowledge workers.
 
@@ -67,6 +67,6 @@
 much prettier cake :)
 '''
 
-__version__ = '0.5.2'
+__version__ = '0.5.3'
 
 # vim: set filetype=python ts=4 sw=4 et si

roundup/cgi/client.py

@@ -1,4 +1,4 @@
-# $Id: client.py,v 1.58 2002-11-28 07:08:39 richard Exp $
+# $Id: client.py,v 1.59 2002-12-10 00:11:15 richard Exp $
 
 __doc__ = """
 WWW request handler (also used in the stand-alone server).
@@ -691,7 +691,7 @@ def editItemAction(self):
             props = self._changenode(props)
             # handle linked nodes 
             self._post_editnode(self.nodeid)
-        except (ValueError, KeyError), message:
+        except (ValueError, KeyError, IndexError), message:
             self.error_message.append(_('Error: ') + str(message))
             return
 
@@ -771,7 +771,19 @@ def newItemAction(self):
         try:
             # do the create
             nid = self._createnode(props)
+        except (ValueError, KeyError, IndexError), message:
+            # these errors might just be indicative of user dumbness
+            self.error_message.append(_('Error: ') + str(message))
+            return
+        except:
+            # oops
+            self.db.rollback()
+            s = StringIO.StringIO()
+            traceback.print_exc(None, s)
+            self.error_message.append('<pre>%s</pre>'%cgi.escape(s.getvalue()))
+            return
 
+        try:
             # handle linked nodes 
             self._post_editnode(nid)
 
@@ -783,9 +795,6 @@ def newItemAction(self):
 
             # and some nice feedback for the user
             message = _('%(classname)s created ok')%self.__dict__ + xtra
-        except (ValueError, KeyError), message:
-            self.error_message.append(_('Error: ') + str(message))
-            return
         except:
             # oops
             self.db.rollback()

roundup/cgi/templating.py

@@ -891,6 +891,12 @@ def pretty(self, format='%d %B %Y'):
         '''
         return self._value.pretty()
 
+    def local(self, offset):
+        ''' Return the date/time as a local (timezone offset) date/time.
+        '''
+        return DateHTMLProperty(self._client, self._nodeid, self._prop,
+            self._name, self._value.local())
+
 class IntervalHTMLProperty(HTMLProperty):
     def plain(self):
         ''' Render a "plain" representation of the property
@@ -965,6 +971,7 @@ def field(self, showid=0, size=None):
         else:
             s = ''
         l.append(_('<option %svalue="-1">- no selection -</option>')%s)
+        # XXX if the current value is retired, then list it explicitly
         for optionid in options:
             # get the option value, and if it's None use an empty string
             option = linkcl.get(optionid, k) or ''
@@ -1011,6 +1018,7 @@ def menu(self, size=None, height=None, showid=0, additional=[],
         else:  
             sort_on = ('+', linkcl.labelprop())
         options = linkcl.filter(None, conditions, sort_on, (None, None))
+        # XXX if the current value is retired, then list it explicitly
         for optionid in options:
             # get the option value, and if it's None use an empty string
             option = linkcl.get(optionid, k) or ''
@@ -1131,6 +1139,7 @@ def menu(self, size=None, height=None, showid=0, additional=[],
         height = height or min(len(options), 7)
         l = ['<select multiple name="%s" size="%s">'%(self._name, height)]
         k = linkcl.labelprop(1)
+        # XXX if any of the current values are retired, then list them
         for optionid in options:
             # get the option value, and if it's None use an empty string
             option = linkcl.get(optionid, k) or ''

roundup/mailgw.py

@@ -73,7 +73,7 @@ class node. Any parts of other types are each stored in separate files
 an exception, the original message is bounced back to the sender with the
 explanatory message given in the exception. 
 
-$Id: mailgw.py,v 1.99 2002-11-05 22:59:46 richard Exp $
+$Id: mailgw.py,v 1.100 2002-12-10 00:11:15 richard Exp $
 '''
 
 import string, re, os, mimetools, cStringIO, smtplib, socket, binascii, quopri
@@ -723,7 +723,11 @@ def handle_message(self, message):
                     attachments.append((name, 'message/rfc822', part.fp.read()))
                 else:
                     # try name on Content-Type
-                    name = part.getparam('name')
+                    name = part.getparam('name').strip()
+                    if not name:
+                        disp = part.getheader('content-disposition', None)
+                        if disp:
+                            name = disp.getparam('filename').strip()
                     # this is just an attachment
                     data = self.get_part_data_decoded(part) 
                     attachments.append((name, part.gettype(), data))
@@ -761,9 +765,9 @@ def handle_message(self, message):
             content = self.get_part_data_decoded(message) 
 
         # figure how much we should muck around with the email body
-        keep_citations = getattr(self.instance, 'EMAIL_KEEP_QUOTED_TEXT',
+        keep_citations = getattr(self.instance.config, 'EMAIL_KEEP_QUOTED_TEXT',
             'no') == 'yes'
-        keep_body = getattr(self.instance, 'EMAIL_LEAVE_BODY_UNCHANGED',
+        keep_body = getattr(self.instance.config, 'EMAIL_LEAVE_BODY_UNCHANGED',
             'no') == 'yes'
 
         # parse the body of the message, stripping out bits as appropriate

roundup/templates/classic/config.py

@@ -15,7 +15,7 @@
 # BASIS, AND THERE IS NO OBLIGATION WHATSOEVER TO PROVIDE MAINTENANCE,
 # SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS.
 # 
-# $Id: config.py,v 1.4 2002-11-07 21:17:44 richard Exp $
+# $Id: config.py,v 1.5 2002-12-10 00:11:16 richard Exp $
 
 import os
 
@@ -47,9 +47,6 @@
 # The email address that roundup will complain to if it runs into trouble
 ADMIN_EMAIL = 'roundup-admin@%s'%MAIL_DOMAIN
 
-# Where to place the web filtering HTML on the index page
-FILTER_POSITION = 'bottom'          # one of 'top', 'bottom', 'top and bottom'
-
 # 
 # SECURITY DEFINITIONS
 #

roundup/templates/classic/html/issue.item

@@ -128,7 +128,7 @@ python:db.user.classhelp('username,realname,address,phone')" /><br>
 
  <table class="messages" tal:condition="context/messages">
   <tr><th colspan="4" class="header">Messages</th></tr>
-  <tal:block tal:repeat="msg context/messages">
+  <tal:block tal:repeat="msg context/messages/reverse">
    <tr>
     <th><a tal:attributes="href string:msg${msg/id}"
            tal:content="string:msg${msg/id}"></a></th>

roundup/templates/minimal/config.py

@@ -15,7 +15,7 @@
 # BASIS, AND THERE IS NO OBLIGATION WHATSOEVER TO PROVIDE MAINTENANCE,
 # SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS.
 # 
-# $Id: config.py,v 1.2 2002-11-07 21:17:44 richard Exp $
+# $Id: config.py,v 1.3 2002-12-10 00:11:16 richard Exp $
 
 import os
 
@@ -47,9 +47,6 @@
 # The email address that roundup will complain to if it runs into trouble
 ADMIN_EMAIL = 'roundup-admin@%s'%MAIL_DOMAIN
 
-# Where to place the web filtering HTML on the index page
-FILTER_POSITION = 'bottom'          # one of 'top', 'bottom', 'top and bottom'
-
 # 
 # SECURITY DEFINITIONS
 #