Clean leaking file descriptors. Eliminates ResourceWarnings.

Author: rouilj

CHANGES.txt

@@ -15,6 +15,10 @@ onwards Python 3.4 and later are also supported.
 
 Fixed:
 
+- issue2551161 - Fix ResourceWarnings when running with -W default.
+  Cleaned up leaking file descriptors from zopetal pre-compile, python
+  module compile and loading localization file. (John Rouillard) 
+
 Features:
 
 - issue2551147 - Enable compression of http responses in roundup.

roundup/cgi/engine_zopetal.py

@@ -42,7 +42,8 @@ def load(self, tplname):
         pt = RoundupPageTemplate()
         # use pt_edit so we can pass the content_type guess too
         content_type = mimetypes.guess_type(filename)[0] or 'text/html'
-        pt.pt_edit(open(src).read(), content_type)
+        with open(src) as srcd:
+            pt.pt_edit(srcd.read(), content_type)
         pt.id = filename
         pt.mtime = stime
         # Add it to the cache.  We cannot do this until the template

roundup/i18n.py

@@ -194,6 +194,7 @@ def get_translation(language=None, tracker_home=None,
                 # note: current implementation of gettext_module
                 #   always adds fallback to the end of the fallback chain.
                 translator.add_fallback(translation_class(mo))
+            mo.close()
         except IOError:
             # ignore unreadable .mo files
             pass

roundup/instance.py

@@ -218,7 +218,8 @@ def nuke(self):
 
     def _compile(self, fname):
         fname = os.path.join(self.tracker_home, fname)
-        return compile(builtins.open(fname).read(), fname, 'exec')
+        with builtins.open(fname) as fnamed:
+            return compile(fnamed.read(), fname, 'exec')
 
     def _exec(self, obj, env):
         if self.libdir: