'Make a Copy' failed with more than one person in nosy list [SF#1906147]

Author: Richard Jones

CHANGES.txt

@@ -1,6 +1,11 @@
 This file contains the changes to the Roundup system over time. The entries
 are given with the most recent entry first.
 
+2008-03-01 1.4.5
+Fixed:
+- 'Make a Copy' failed with more than one person in nosy list (sf #1906147)
+
+
 2008-03-01 1.4.4
 Fixed:
 - Security fixes (thanks Roland Meister)

roundup/cgi/templating.py

@@ -2134,7 +2134,7 @@ def handleListCGIValue(value):
         value = value.value.strip()
         if not value:
             return []
-        return value.split(',')
+        return [v.strip() for v in value.split(',')]
 
 class HTMLRequest(HTMLInputMixin):
     """The *request*, holding the CGI form and environment.

test/test_templating.py

@@ -12,7 +12,8 @@ class TemplatingTestCase(unittest.TestCase):
     def setUp(self):
         self.form = FieldStorage()
         self.client = MockNull()
-        self.client.db = MockDatabase()
+        self.client.db = db = MockDatabase()
+        db.security.hasPermission = lambda *args, **kw: True
         self.client.form = self.form
 
 class HTMLDatabaseTestCase(TemplatingTestCase):
@@ -69,6 +70,24 @@ def get(entry, key):
         self.assertEqual(lookupKeys(shrubbery, 'spam', ['ok','2']), ['ok',
             'eggs'])
 
+class HTMLClassTestCase(TemplatingTestCase) :
+
+    def test_multilink(self):
+        """`lookup` of an item will fail if leading or trailing whitespace
+           has not been stripped.
+        """
+        def lookup(key) :
+            self.assertEqual(key, key.strip())
+            return "User%s"%key
+        self.form.list.append(MiniFieldStorage("nosy", "1, 2"))
+        nosy = hyperdb.Multilink("user")
+        self.client.db.classes = dict \
+            ( issue = MockNull(getprops = lambda : dict(nosy = nosy))
+            , user  = MockNull(get = lambda id, name : id, lookup = lookup)
+            )
+        cls = HTMLClass(self.client, "issue")
+        cls["nosy"]
+
 '''
 class HTMLPermissions:
     def is_edit_ok(self):
@@ -243,6 +262,7 @@ def test_suite():
     suite = unittest.TestSuite()
     suite.addTest(unittest.makeSuite(HTMLDatabaseTestCase))
     suite.addTest(unittest.makeSuite(FunctionsTestCase))
+    suite.addTest(unittest.makeSuite(HTMLClassTestCase))
     return suite
 
 if __name__ == '__main__':