Skip to content

Commit 753e8d6

Browse files
author
Richard Jones
committed
https URLs from config now recognised as valid [SF#619829]
1 parent e67354d commit 753e8d6

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

CHANGES.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ are given with the most recent entry first.
1010
- fixed register with no session (sf bug 618611)
1111
- fixed log / pid file path handling in roundup-server (sf bug 617981)
1212
- fixed old gadfly compatibiltiy problem, for sure this time (sf bug 612873)
13+
- https URLs from config now recognised as valid (sf bug 619829)
1314

1415

1516
2002-10-02 0.5.0

roundup/roundupdb.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
# BASIS, AND THERE IS NO OBLIGATION WHATSOEVER TO PROVIDE MAINTENANCE,
1616
# SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS.
1717
#
18-
# $Id: roundupdb.py,v 1.69 2002-09-20 01:20:31 richard Exp $
18+
# $Id: roundupdb.py,v 1.70 2002-10-08 03:27:24 richard Exp $
1919

2020
__doc__ = """
2121
Extending hyperdb with types specific to issue-tracking.
@@ -290,7 +290,9 @@ def email_signature(self, nodeid, msgid):
290290
# simplistic check to see if the url is valid,
291291
# then append a trailing slash if it is missing
292292
base = self.db.config.TRACKER_WEB
293-
if not isinstance(base , type('')) or not base.startswith('http://'):
293+
if (not isinstance(base , type('')) or
294+
not base.startswith('http://'):
295+
not base.startswith('https://')):
294296
base = "Configuration Error: TRACKER_WEB isn't a " \
295297
"fully-qualified URL"
296298
elif base[-1] != '/' :

0 commit comments

Comments
 (0)