Skip to content

Commit 6f247e0

Browse files
committed
Apply patch attached to issue2550937 traceback/crash due to passing
empty sendto to smtp_send. Fix by Trent Gamblin. http://issues.roundup-tracker.org/issue2550937
1 parent 9b70285 commit 6f247e0

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

CHANGES.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -424,6 +424,9 @@ Fixed:
424424
permissions check was changed to require that the user have View
425425
access to the labelprop for the class rather than View access to the
426426
class. (John Rouillard)
427+
- issue2550937: fix crash by verifying that sendto is not null before
428+
calling mailer.smtp_send. Discovered and patched by Trent Gamblin.
429+
Applied by John Rouillard.
427430

428431
2016-01-11: 1.5.1
429432

roundup/roundupdb.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -658,7 +658,8 @@ def send_message(self, issueid, msgid, note, sendto, from_address=None,
658658
if message.get ('In-Reply-To'):
659659
send_msg ['In-Reply-To'] = message ['In-Reply-To']
660660

661-
mailer.smtp_send(sendto, send_msg.as_string())
661+
if sendto:
662+
mailer.smtp_send(sendto, send_msg.as_string())
662663
if first:
663664
if crypt:
664665
# send individual bcc mails, otherwise receivers can

0 commit comments

Comments
 (0)