Skip to content

Commit 6e62a80

Browse files
committed
Provide a a "no selection" option; cleanup.
1 parent 7f07fc3 commit 6e62a80

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

roundup/cgi/templating.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2119,10 +2119,9 @@ def menu(self, size=None, height=None, showid=0, additional=[],
21192119
l = ['<select multiple name="%s" size="%s">'%(self._formname, height)]
21202120
k = linkcl.labelprop(1)
21212121

2122-
# make sure we list the current values if they're retired
2123-
for val in value:
2124-
if val not in options:
2125-
options.insert(0, val)
2122+
if value:
2123+
l.append('<option value="%s">- no selection -</option>'
2124+
% ','.join(['-' + v for v in value]))
21262125

21272126
if additional:
21282127
additional_fns = []

0 commit comments

Comments
 (0)